Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

chore(reduce_honeybadger_noise): saveCheckFromTimeMachine was reporting Honeybadger errors when users were trying to save checks with the same name. (#18188)

pull/18194/head
Ariel Salem 2020-05-21 12:21:12 -07:00 committed by GitHub
parent 99074a262d
commit bf13e339fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ui/src/checks/actions/thunks.ts
View File

@ -19,6 +19,7 @@ import {createView} from 'src/views/helpers'
import {getOrg} from 'src/organizations/selectors' import {getOrg} from 'src/organizations/selectors'
import {toPostCheck, builderToPostCheck} from 'src/checks/utils' import {toPostCheck, builderToPostCheck} from 'src/checks/utils'
import {getAll, getStatus} from 'src/resources/selectors' import {getAll, getStatus} from 'src/resources/selectors'
import {getErrorMessage} from 'src/utils/api'
// Actions // Actions
import { import {
@ -151,17 +152,14 @@ export const createCheckFromTimeMachine = () => async (
dispatch: Dispatch<Action | SendToTimeMachineAction>, dispatch: Dispatch<Action | SendToTimeMachineAction>,
getState: GetState getState: GetState
): Promise<void> => { ): Promise<void> => {
const rename = 'Please rename the check before saving'
try { try {
const state = getState() const state = getState()
const check = builderToPostCheck(state) const check = builderToPostCheck(state)
const resp = await api.postCheck({data: check}) const resp = await api.postCheck({data: check})
if (resp.status !== 201) { if (resp.status !== 201) {
if (resp.data.code.includes('conflict')) { if (resp.data.code.includes('conflict')) {
throw new Error( throw new Error(`A check named ${check.name} already exists. ${rename}`)
`A check named ${
check.name
} already exists. Please rename the check before saving`
)
} }
throw new Error(resp.data.message) throw new Error(resp.data.message)
} }
@ -178,11 +176,14 @@ export const createCheckFromTimeMachine = () => async (
dispatch(resetAlertBuilder()) dispatch(resetAlertBuilder())
} catch (error) { } catch (error) {
console.error(error) console.error(error)
dispatch(notify(copy.createCheckFailed(error.message))) const message = getErrorMessage(error)
reportError(error, { dispatch(notify(copy.createCheckFailed(message)))
context: {state: getState()}, if (!message.includes(rename)) {
name: 'saveCheckFromTimeMachine function', reportError(error, {
}) context: {state: getState()},
name: 'saveCheckFromTimeMachine function',
})
}
} }
} }