feat: Don't actually compact anything if you're running in cold compaction mode

pull/24376/head
Carol (Nichols || Goulding) 2023-04-14 17:05:17 -04:00
parent 9350b64314
commit bb02e1ce1b
No known key found for this signature in database
GPG Key ID: E907EE5A736F87D4
1 changed files with 6 additions and 3 deletions

View File

@ -8,7 +8,7 @@ use data_types::CompactionLevel;
use object_store::memory::InMemory;
use crate::{
config::{Config, PartitionsSourceConfig},
config::{CompactionType, Config, PartitionsSourceConfig},
error::ErrorKind,
object_store::ignore_writes::IgnoreWrites,
};
@ -166,7 +166,10 @@ fn make_partitions_source_commit_partition_sink(
partitions_source,
);
let partition_done_sink: Arc<dyn PartitionDoneSink> = if config.shadow_mode {
// Temporarily do nothing for cold compaction until we check the cold compaction selection.
let shadow_mode = config.shadow_mode || config.compaction_type == CompactionType::Cold;
let partition_done_sink: Arc<dyn PartitionDoneSink> = if shadow_mode {
Arc::new(MockPartitionDoneSink::new())
} else {
Arc::new(CatalogPartitionDoneSink::new(
@ -175,7 +178,7 @@ fn make_partitions_source_commit_partition_sink(
))
};
let commit: Arc<dyn Commit> = if config.shadow_mode {
let commit: Arc<dyn Commit> = if shadow_mode {
Arc::new(MockCommit::new())
} else {
Arc::new(CatalogCommit::new(