Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Ensure error don't end in punctuation: ST1005

pull/10616/head
Edd Robinson 2018-11-21 14:24:14 +00:00
parent 9403c1ec8e
commit b81b30ee87
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bolt/keyvalue_log.go
View File

@ -192,7 +192,7 @@ func (c *Client) forEachLogEntry(ctx context.Context, tx *bolt.Tx, k []byte, opt
k, v := cur.Seek(startKey) k, v := cur.Seek(startKey)
if !bytes.Equal(k, startKey) { if !bytes.Equal(k, startKey) {
return fmt.Errorf("the first key not the key found in the log bounds. This should be impossible. Please report this error.") return fmt.Errorf("the first key not the key found in the log bounds. This should be impossible. Please report this error")
} }
count := 0 count := 0

2
bolt/secret.go
View File

@ -162,7 +162,7 @@ func encodeSecretKey(orgID platform.ID, k string) ([]byte, error) {
func decodeSecretKey(key []byte) (platform.ID, string, error) { func decodeSecretKey(key []byte) (platform.ID, string, error) {
if len(key) < platform.IDLength { if len(key) < platform.IDLength {
// This should not happen. // This should not happen.
return platform.InvalidID(), "", errors.New("provided key is too short to contain an ID. Please report this error.") return platform.InvalidID(), "", errors.New("provided key is too short to contain an ID. Please report this error")
} }
var id platform.ID var id platform.ID

2
chronograf/server/users.go
View File

@ -356,7 +356,7 @@ func setSuperAdmin(ctx context.Context, req userRequest, user *chronograf.User)
} else if !isSuperAdmin && (user.SuperAdmin != req.SuperAdmin) { } else if !isSuperAdmin && (user.SuperAdmin != req.SuperAdmin) {
// If req.SuperAdmin has been set, and the request was not made with the SuperAdmin // If req.SuperAdmin has been set, and the request was not made with the SuperAdmin
// context, return error // context, return error
return fmt.Errorf("user does not have authorization required to set SuperAdmin status. See https://github.com/influxdata/platform/chronograf/issues/2601 for more information.") return fmt.Errorf("user does not have authorization required to set SuperAdmin status. See https://github.com/influxdata/platform/chronograf/issues/2601 for more information")
} }
return nil return nil

4
chronograf/server/users_test.go
View File

@ -354,7 +354,7 @@ func TestService_NewUser(t *testing.T) {
}, },
wantStatus: http.StatusUnauthorized, wantStatus: http.StatusUnauthorized,
wantContentType: "application/json", wantContentType: "application/json",
wantBody: `{"code":401,"message":"user does not have authorization required to set SuperAdmin status. See https://github.com/influxdata/platform/chronograf/issues/2601 for more information."}`, wantBody: `{"code":401,"message":"user does not have authorization required to set SuperAdmin status. See https://github.com/influxdata/platform/chronograf/issues/2601 for more information"}`,
}, },
{ {
name: "Create a new SuperAdmin User - as superadmin", name: "Create a new SuperAdmin User - as superadmin",
@ -1264,7 +1264,7 @@ func TestService_UpdateUser(t *testing.T) {
id: "1336", id: "1336",
wantStatus: http.StatusUnauthorized, wantStatus: http.StatusUnauthorized,
wantContentType: "application/json", wantContentType: "application/json",
wantBody: `{"code":401,"message":"user does not have authorization required to set SuperAdmin status. See https://github.com/influxdata/platform/chronograf/issues/2601 for more information."}`, wantBody: `{"code":401,"message":"user does not have authorization required to set SuperAdmin status. See https://github.com/influxdata/platform/chronograf/issues/2601 for more information"}`,
}, },
{ {
name: "Update a Chronograf user to super admin - with super admin context", name: "Update a Chronograf user to super admin - with super admin context",

2
nats/server.go
View File

@ -9,7 +9,7 @@ import (
const ServerName = "platform" const ServerName = "platform"
var ErrNoNatsConnection = errors.New("nats connection has not been established. Call Open() first.") var ErrNoNatsConnection = errors.New("nats connection has not been established. Call Open() first")
// Server wraps a connection to a NATS streaming server // Server wraps a connection to a NATS streaming server
type Server struct { type Server struct {