Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ci: remove 2/3 disabled exit-non-zero flags for megacheck 

The one remaining failing static check is in a pigeon-generated promql
file. It looks like megacheck is supposed to ignore generated files by
default, so it's unclear at this time if this is a bug in megacheck, or
if fixing pigeon is the only path forward.
pull/10616/head
Mark Rushakoff 2018-11-01 12:11:53 -07:00
parent ff2998dcf8
commit b37279c50e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.circleci/config.yml
View File

@ -57,10 +57,11 @@ jobs:
# TODO add these checks to the Makefile # TODO add these checks to the Makefile
# - run: go get -v -t -d ./... # - run: go get -v -t -d ./...
# TODO(#544): fix all the megacheck errors, and drop the exit-non-zero flags so that megacheck failures break the build. # TODO(#544): fix the remaining static check in the generated promql file, and enable exit-non-zero.
# Not yet sure if that's a bug in staticcheck or if we need to submit a patch to pigeon to fix the generator.
- run: GO111MODULE=on go mod vendor # This seems to be necessary to get megacheck to work with modules. - run: GO111MODULE=on go mod vendor # This seems to be necessary to get megacheck to work with modules.
- run: go get honnef.co/go/tools/cmd/megacheck - run: go get honnef.co/go/tools/cmd/megacheck
- run: megacheck -simple.exit-non-zero=false -staticcheck.exit-non-zero=false -unused.exit-non-zero=false ./... - run: megacheck -staticcheck.exit-non-zero=false ./...
- save_cache: - save_cache:
name: Saving GOCACHE name: Saving GOCACHE