Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor(ingester): Use separate attribute for ingester WAL replay failure reason 

By separating the failure reason from the result of the WAL file replay
metric, it keeps flexibility to include other failure modes in future.
pull/24376/head
Fraser Savage 2023-09-18 14:11:26 +01:00
parent 2546fbb796
commit b179076011
No known key found for this signature in database
GPG Key ID: DE47C33CE8C5C446
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ingester/src/init/wal_replay.rs
View File

@ -138,9 +138,9 @@ where
"ingester_wal_replay_files_finished",
"Number of WAL files that have been replayed",
);
let whole_file_count_metric = replayed_file_count_metric.recorder(&[("outcome", "whole")]);
let truncated_file_count_metric =
replayed_file_count_metric.recorder(&[("outcome", "truncated")]);
let file_count_success_metric = replayed_file_count_metric.recorder(&[("result", "success")]);
let file_count_error_truncated_metric =
replayed_file_count_metric.recorder(&[("result", "error"), ("reason", "truncated")]);
let op_count_metric = metrics.register_metric::<U64Counter>(
"ingester_wal_replay_ops",
@ -183,7 +183,7 @@ where
let replay_result = replay_file(reader, sink, &ok_op_count_metric, &empty_op_count_metric)
.await
.map(|v| {
whole_file_count_metric.inc(1);
file_count_success_metric.inc(1);
v
})
.map_err(|e| {
@ -193,7 +193,7 @@ where
{
if io_err.kind() == std::io::ErrorKind::UnexpectedEof && file_number == n_files {
max_sequence = max_sequence.max(*seq);
truncated_file_count_metric.inc(1);
file_count_error_truncated_metric.inc(1);
warn!(%e, %file_id, "detected truncated WAL write, ending replay for file early");
return Ok(None);
}
@ -620,14 +620,17 @@ mod tests {
let whole_files = metrics
.get_instrument::<Metric<U64Counter>>("ingester_wal_replay_files_finished")
.expect("file counter not found")
.get_observer(&Attributes::from(&[("outcome", "whole")]))
.get_observer(&Attributes::from(&[("result", "success")]))
.expect("attributes not found")
.fetch();
assert_eq!(whole_files, 3);
let truncated_files = metrics
.get_instrument::<Metric<U64Counter>>("ingester_wal_replay_files_finished")
.expect("file counter not found")
.get_observer(&Attributes::from(&[("outcome", "truncated")]))
.get_observer(&Attributes::from(&[
("result", "error"),
("reason", "truncated"),
]))
.expect("attributes not found")
.fetch();
assert_eq!(truncated_files, 0);
@ -800,14 +803,17 @@ mod tests {
let whole_files = metrics
.get_instrument::<Metric<U64Counter>>("ingester_wal_replay_files_finished")
.expect("file counter not found")
.get_observer(&Attributes::from(&[("outcome", "whole")]))
.get_observer(&Attributes::from(&[("result", "success")]))
.expect("attributes not found")
.fetch();
assert_eq!(whole_files, 2);
let truncated_files = metrics
.get_instrument::<Metric<U64Counter>>("ingester_wal_replay_files_finished")
.expect("file counter not found")
.get_observer(&Attributes::from(&[("outcome", "truncated")]))
.get_observer(&Attributes::from(&[
("result", "error"),
("reason", "truncated"),
]))
.expect("attributes not found")
.fetch();
assert_eq!(truncated_files, 1);