Fix issue rendering undefined points in Histogram

2019-02-22 15:17:35 -08:00 · 2019-02-22 15:17:35 -08:00 · b073c84b7e
parent 2aef8e8eef
commit b073c84b7e
1 changed files with 8 additions and 1 deletions
--- a/ui/src/minard/utils/bin.ts
+++ b/ui/src/minard/utils/bin.ts
@ -70,7 +70,14 @@ export const bin = (
  for (let i = 0; i < xCol.length; i++) {
    const x = xCol[i]

-    if (x < xDomain[0] || x > xDomain[1]) {
+    const shouldSkipPoint =
+      x === undefined ||
+      x === null ||
+      isNaN(x) ||
+      x < xDomain[0] ||
+      x > xDomain[1]
+
+    if (shouldSkipPoint) {
      continue
    }