select * from foo where a == 2; should return all columns not just 'a'

pull/17/head
John Shahid 2013-11-01 16:06:01 -04:00
parent 638293fe1c
commit aeaef15a94
2 changed files with 5 additions and 5 deletions

View File

@ -61,7 +61,7 @@ func (self *Query) GetReferencedColumns() map[*Value][]string {
name := value.Name name := value.Name
returnedMapping[value] = uniq(append(mapping[name], notPrefixedColumns...)) returnedMapping[value] = uniq(append(mapping[name], notPrefixedColumns...))
if len(returnedMapping[value]) > 1 && returnedMapping[value][0] == "*" { if len(returnedMapping[value]) > 1 && returnedMapping[value][0] == "*" {
returnedMapping[value] = returnedMapping[value][1:] returnedMapping[value] = returnedMapping[value][:1]
} }
delete(mapping, name) delete(mapping, name)

View File

@ -103,15 +103,15 @@ func (self *QueryApiSuite) TestGetReferencedColumnsWithARegexTable(c *C) {
} }
} }
func (self *QueryApiSuite) TestGetReferencedColumnsReturnsGroupByColumn(c *C) { func (self *QueryApiSuite) TestGetReferencedColumnsWithWhereClause(c *C) {
queryStr := "select count(*), region from events group by time(1h), region;" queryStr := "select * from foo where a == 5;"
query, err := ParseQuery(queryStr) query, err := ParseQuery(queryStr)
c.Assert(err, IsNil) c.Assert(err, IsNil)
columns := query.GetReferencedColumns() columns := query.GetReferencedColumns()
c.Assert(columns, HasLen, 1) c.Assert(columns, HasLen, 1)
for v, columns := range columns { for v, columns := range columns {
c.Assert(v.Name, Equals, "events") c.Assert(v.Name, Equals, "foo")
c.Assert(columns, DeepEquals, []string{"region"}) c.Assert(columns, DeepEquals, []string{"*"})
} }
} }