From 3ee2599744b782c18a47dc6c87ffe48d0488f56b Mon Sep 17 00:00:00 2001
From: Palak Bhojani <palak@influxdata.com>
Date: Wed, 27 Feb 2019 15:53:12 -0800
Subject: [PATCH] test(scrapers): add test for creating scrapers

---
 ui/cypress/e2e/scrapers.test.ts               | 40 +++++++++++++++++++
 .../configureStep/ScraperTarget.tsx           |  2 +
 .../__snapshots__/ScraperTarget.test.tsx.snap | 16 ++++----
 3 files changed, 50 insertions(+), 8 deletions(-)
 create mode 100644 ui/cypress/e2e/scrapers.test.ts

diff --git a/ui/cypress/e2e/scrapers.test.ts b/ui/cypress/e2e/scrapers.test.ts
new file mode 100644
index 0000000000..c90cdd31c4
--- /dev/null
+++ b/ui/cypress/e2e/scrapers.test.ts
@@ -0,0 +1,40 @@
+describe('Scrapers', () => {
+  beforeEach(() => {
+    cy.flush()
+
+    cy.signin().then(({body}) => {
+      const {
+        org: {id},
+      } = body
+      cy.fixture('routes').then(({orgs}) => {
+        cy.visit(`${orgs}/${id}/scrapers_tab`)
+      })
+    })
+  })
+
+  describe('from the org view', () => {
+    it('can create a scraper', () => {
+      const newScraper = 'Scraper'
+      const newURL = 'http://google.com'
+
+      cy.getByTestID('table-row').should('have.length', 0)
+
+      cy.contains('Create').click()
+      cy.getByTestID('overlay--container').within(() => {
+        cy.getByInputName('name')
+          .clear()
+          .type(newScraper)
+        cy.getByInputName('url')
+          .clear()
+          .type(newURL)
+        cy.get('.button')
+          .contains('Finish')
+          .click()
+      })
+
+      cy.getByTestID('table-row')
+        .should('have.length', 1)
+        .and('contain', newScraper)
+    })
+  })
+})
diff --git a/ui/src/dataLoaders/components/configureStep/ScraperTarget.tsx b/ui/src/dataLoaders/components/configureStep/ScraperTarget.tsx
index 0c71b7bd3c..271aea8a7a 100644
--- a/ui/src/dataLoaders/components/configureStep/ScraperTarget.tsx
+++ b/ui/src/dataLoaders/components/configureStep/ScraperTarget.tsx
@@ -42,6 +42,7 @@ export class ScraperTarget extends PureComponent<Props> {
               <Input
                 type={InputType.Text}
                 value={name}
+                name="name"
                 onChange={this.handleChangeName}
                 titleText="Name"
                 size={ComponentSize.Medium}
@@ -65,6 +66,7 @@ export class ScraperTarget extends PureComponent<Props> {
               <Input
                 type={InputType.Text}
                 value={url}
+                name="url"
                 onChange={this.handleChangeURL}
                 titleText="Target URL"
                 size={ComponentSize.Medium}
diff --git a/ui/src/dataLoaders/components/configureStep/__snapshots__/ScraperTarget.test.tsx.snap b/ui/src/dataLoaders/components/configureStep/__snapshots__/ScraperTarget.test.tsx.snap
index 9e46beeb03..51528bb0fe 100644
--- a/ui/src/dataLoaders/components/configureStep/__snapshots__/ScraperTarget.test.tsx.snap
+++ b/ui/src/dataLoaders/components/configureStep/__snapshots__/ScraperTarget.test.tsx.snap
@@ -15,7 +15,7 @@ exports[`ScraperTarget rendering renders correctly with bucket 1`] = `
           autoFocus={true}
           autocomplete="off"
           disabledTitleText="This input is disabled"
-          name=""
+          name="name"
           onChange={[Function]}
           placeholder=""
           size="md"
@@ -49,7 +49,7 @@ exports[`ScraperTarget rendering renders correctly with bucket 1`] = `
           autoFocus={false}
           autocomplete="off"
           disabledTitleText="This input is disabled"
-          name=""
+          name="url"
           onChange={[Function]}
           placeholder=""
           size="md"
@@ -81,7 +81,7 @@ exports[`ScraperTarget rendering renders correctly with name 1`] = `
           autoFocus={true}
           autocomplete="off"
           disabledTitleText="This input is disabled"
-          name=""
+          name="name"
           onChange={[Function]}
           placeholder=""
           size="md"
@@ -115,7 +115,7 @@ exports[`ScraperTarget rendering renders correctly with name 1`] = `
           autoFocus={false}
           autocomplete="off"
           disabledTitleText="This input is disabled"
-          name=""
+          name="url"
           onChange={[Function]}
           placeholder=""
           size="md"
@@ -147,7 +147,7 @@ exports[`ScraperTarget rendering renders correctly with no bucket, url, name 1`]
           autoFocus={true}
           autocomplete="off"
           disabledTitleText="This input is disabled"
-          name=""
+          name="name"
           onChange={[Function]}
           placeholder=""
           size="md"
@@ -181,7 +181,7 @@ exports[`ScraperTarget rendering renders correctly with no bucket, url, name 1`]
           autoFocus={false}
           autocomplete="off"
           disabledTitleText="This input is disabled"
-          name=""
+          name="url"
           onChange={[Function]}
           placeholder=""
           size="md"
@@ -213,7 +213,7 @@ exports[`ScraperTarget rendering renders correctly with url 1`] = `
           autoFocus={true}
           autocomplete="off"
           disabledTitleText="This input is disabled"
-          name=""
+          name="name"
           onChange={[Function]}
           placeholder=""
           size="md"
@@ -247,7 +247,7 @@ exports[`ScraperTarget rendering renders correctly with url 1`] = `
           autoFocus={false}
           autocomplete="off"
           disabledTitleText="This input is disabled"
-          name=""
+          name="url"
           onChange={[Function]}
           placeholder=""
           size="md"