fix: Remove db_name field from DeletePayload

Doesn't seem to be used anywhere.
pull/24376/head
Carol (Nichols || Goulding) 2022-11-14 15:22:12 -05:00
parent f4b8fe7751
commit 8dbdab8754
No known key found for this signature in database
GPG Key ID: E907EE5A736F87D4
3 changed files with 4 additions and 8 deletions

View File

@ -35,8 +35,9 @@ message DeleteResponse {
// A delete payload
message DeletePayload {
// The name of the database
string db_name = 1;
// Was the name of the database / namespace.
reserved "db_name";
reserved 1;
// The catalog ID for this database / namespace.
int64 database_id = 4;

View File

@ -52,7 +52,6 @@ pub mod generated_types {
/// };
/// client
/// .delete(
/// "my_db",
/// 42,
/// "my_table",
/// pred,
@ -77,18 +76,15 @@ impl Client {
/// Delete data from a table on a specified predicate
pub async fn delete(
&mut self,
db_name: impl Into<String> + Send,
database_id: i64,
table_name: impl Into<String> + Send,
predicate: Predicate,
) -> Result<(), Error> {
let db_name = db_name.into();
let table_name = table_name.into();
self.inner
.delete(DeleteRequest {
payload: Some(DeletePayload {
db_name,
database_id,
table_name,
predicate: Some(predicate),

View File

@ -207,7 +207,7 @@ pub fn decode(
/// Encodes a [`DmlOperation`] as a protobuf [`WriteBufferPayload`]
pub fn encode_operation(
db_name: &str,
_db_name: &str,
operation: &DmlOperation,
buf: &mut Vec<u8>,
) -> Result<(), WriteBufferError> {
@ -218,7 +218,6 @@ pub fn encode_operation(
Payload::Write(batch)
}
DmlOperation::Delete(delete) => Payload::Delete(DeletePayload {
db_name: db_name.to_string(),
database_id: delete.namespace_id().get(),
table_name: delete
.table_name()