Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(task): populate created task response, the same as finding 

The response from a created task was missing the name field; now a test
ensures that response matches what is returned when listing tasks.
pull/11389/head
Mark Rushakoff 2019-01-22 10:49:35 -08:00 committed by Mark Rushakoff
parent 0cfc99c5fe
commit 882750c751
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
task/platform_adapter.go
View File

@ -75,7 +75,7 @@ func (p pAdapter) CreateTask(ctx context.Context, t *platform.Task) error {
return err return err
} }
// TODO(mr): decide whether we allow user to configure scheduleAfter. https://github.com/influxdata/influxdb/issues/595 // TODO(mr): decide whether we allow user to configure scheduleAfter. https://github.com/influxdata/influxdb/issues/10884
scheduleAfter := time.Now().Unix() scheduleAfter := time.Now().Unix()
if t.Status == "" { if t.Status == "" {
@ -95,8 +95,15 @@ func (p pAdapter) CreateTask(ctx context.Context, t *platform.Task) error {
return err return err
} }
t.ID = id t.ID = id
t.Every = opts.Every.String()
t.Cron = opts.Cron t.Cron = opts.Cron
t.Name = opts.Name
if opts.Every != 0 {
t.Every = opts.Every.String()
}
if opts.Offset != 0 {
t.Offset = opts.Offset.String()
}
return nil return nil
} }

4
task/servicetest/servicetest.go
View File

@ -122,7 +122,9 @@ func testTaskCRUD(t *testing.T, sys *System) {
// Look up a task the different ways we can. // Look up a task the different ways we can.
// Map of method name to found task. // Map of method name to found task.
found := make(map[string]*platform.Task) found := map[string]*platform.Task{
"Created": task,
}
// Find by ID should return the right task. // Find by ID should return the right task.
f, err := sys.ts.FindTaskByID(sys.Ctx, task.ID) f, err := sys.ts.FindTaskByID(sys.Ctx, task.ID)