Pull WithDefaults from collectd and openTSDB

This pattern, which is present in Graphite, is not needed for collectd
and openTSDB.

services/collectd/config.go

@@ -42,28 +42,3 @@ func NewConfig() Config {
 		TypesDB:         DefaultTypesDB,
 	}
 }
-
-// WithDefaults takes the given config and returns a new config with any required
-// default values set.
-func (c *Config) WithDefaults() *Config {
-	d := *c
-	if d.BindAddress == "" {
-		d.BindAddress = DefaultBindAddress
-	}
-	if d.Database == "" {
-		d.Database = DefaultDatabase
-	}
-	if d.RetentionPolicy == "" {
-		d.RetentionPolicy = DefaultRetentionPolicy
-	}
-	if d.BatchSize == 0 {
-		d.BatchSize = DefaultBatchSize
-	}
-	if d.BatchDuration == 0 {
-		d.BatchDuration = DefaultBatchDuration
-	}
-	if d.TypesDB == "" {
-		d.TypesDB = DefaultTypesDB
-	}
-	return &d
-}

services/collectd/service.go

@@ -47,7 +47,7 @@ type Service struct {
 // NewService returns a new instance of the collectd service.
 func NewService(c Config) *Service {
 	s := &Service{
-		Config: c.WithDefaults(),
+		Config: &c,
 		Logger: log.New(os.Stderr, "[collectd] ", log.LstdFlags),
 		err:    make(chan error),
 	}

services/opentsdb/config.go

@@ -30,22 +30,3 @@ func NewConfig() Config {
 		ConsistencyLevel: DefaultConsistencyLevel,
 	}
 }
-
-// WithDefaults takes the given config and returns a new config with any required
-// default values set.
-func (c *Config) WithDefaults() *Config {
-	d := *c
-	if d.BindAddress == "" {
-		d.BindAddress = DefaultBindAddress
-	}
-	if d.Database == "" {
-		d.Database = DefaultDatabase
-	}
-	if d.RetentionPolicy == "" {
-		d.RetentionPolicy = DefaultRetentionPolicy
-	}
-	if d.ConsistencyLevel == "" {
-		d.ConsistencyLevel = DefaultConsistencyLevel
-	}
-	return &d
-}

services/opentsdb/service.go

@@ -47,19 +47,16 @@ type Service struct {
 
 // NewService returns a new instance of Service.
 func NewService(c Config) (*Service, error) {
-	// Use defaults where necessary.
+	consistencyLevel, err := cluster.ParseConsistencyLevel(c.ConsistencyLevel)
-	d := c.WithDefaults()
-
-	consistencyLevel, err := cluster.ParseConsistencyLevel(d.ConsistencyLevel)
 	if err != nil {
 		return nil, err
 	}
 
 	s := &Service{
 		err:              make(chan error),
-		BindAddress:      d.BindAddress,
+		BindAddress:      c.BindAddress,
-		Database:         d.Database,
+		Database:         c.Database,
-		RetentionPolicy:  d.RetentionPolicy,
+		RetentionPolicy:  c.RetentionPolicy,
 		ConsistencyLevel: consistencyLevel,
 		Logger:           log.New(os.Stderr, "[opentsdb] ", log.LstdFlags),
 	}