Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: reduce log verbosity for `found compaction candidates` message (#5225) 

* fix: reduce log verbosity

* refactor: sleep for a sec if no work, print debug

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
pull/24376/head
Andrew Lamb 2022-07-27 15:35:31 -04:00 committed by GitHub
parent 9da8062a16
commit 7eebe061a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
compactor/src/handler.rs
View File

@ -15,7 +15,10 @@ use observability_deps::tracing::*;
use parquet_file::storage::ParquetStorage;
use std::sync::Arc;
use thiserror::Error;
use tokio::task::{JoinError, JoinHandle};
use tokio::{
task::{JoinError, JoinHandle},
time::Duration,
};
use tokio_util::sync::CancellationToken;
use crate::compact::Compactor;
@ -230,6 +233,10 @@ impl CompactorConfig {
}
}
/// How long to pause before checking for more work again if there was
/// no work to do
const PAUSE_BETWEEN_NO_WORK: Duration = Duration::from_secs(1);
/// Checks for candidate partitions to compact and spawns tokio tasks to compact as many
/// as the configuration will allow. Once those are done it rechecks the catalog for the
/// next top partitions to compact.
@ -281,7 +288,13 @@ async fn run_compactor(compactor: Arc<Compactor>, shutdown: CancellationToken) {
}
let n_candidates = candidates.len();
debug!(n_candidates, "found compaction candidates");
if n_candidates == 0 {
// sleep for a second to avoid a hot busy loop when the
// catalog is polled
tokio::time::sleep(PAUSE_BETWEEN_NO_WORK).await
} else {
debug!(n_candidates, "found compaction candidates");
}
// Serially compact all candidates
// TODO: we will parallelize this when everything runs smoothly in serial