task(fix): Tasks should no longer have inaccurate response data (#13641)

* task(fix): Tasks should no longer have inaccurate response data
tasks should be able to pull from a table with both success and failed results

Co-authored-by: AlirieGray <alirie@influxdata.com>
Co-authored-by: docmerlin <emrys@influxdata.com>

task/backend/query_logreader.go

@@ -310,10 +310,12 @@ func (re *runExtractor) extractRecord(cr flux.ColReader) error {
 					r.Status = col.Label
 				}
 			case RunSuccess.String(), RunFail.String(), RunCanceled.String():
-				r.FinishedAt = values.Time(cr.Times(j).Value(i)).Time().Format(time.RFC3339Nano)
-				// Finished can be set unconditionally;
-				// it's fine to overwrite if the status was already set to started.
-				r.Status = col.Label
+				if cr.Times(j).Value(i) != 0 {
+					r.FinishedAt = values.Time(cr.Times(j).Value(i)).Time().Format(time.RFC3339Nano)
+					// Finished can be set unconditionally;
+					// it's fine to overwrite if the status was already set to started.
+					r.Status = col.Label
+				}
 			}
 		}
 

task/backend/storetest/logstoretest.go

@@ -113,6 +113,49 @@ func updateRunState(t *testing.T, crf CreateRunStoreFunc, drf DestroyRunStoreFun
 	if diff := cmp.Diff(run, *returnedRun); diff != "" {
 		t.Fatalf("unexpected run found: -want/+got: %s", diff)
 	}
+
+	now = time.Now().UTC()
+
+	// create a failed run
+	scheduledFor2 := now.Add(-2 * time.Second)
+	run2 := platform.Run{
+		ID:           platformtesting.MustIDBase16("2c20766972747574"),
+		TaskID:       task.ID,
+		Status:       "started",
+		ScheduledFor: scheduledFor2.Format(time.RFC3339),
+	}
+	rlb2 := backend.RunLogBase{
+		Task:            task,
+		RunID:           run2.ID,
+		RunScheduledFor: scheduledFor2.Unix(),
+	}
+
+	startAt2 := now.Add(-1 * time.Second)
+	if err := writer.UpdateRunState(ctx, rlb2, startAt2, backend.RunStarted); err != nil {
+		t.Fatal(err)
+	}
+	endAt2 := now.Add(-1 * time.Millisecond)
+	if err := writer.UpdateRunState(ctx, rlb2, endAt2, backend.RunFail); err != nil {
+		t.Fatal(err)
+	}
+	run2.StartedAt = startAt2.Format(time.RFC3339Nano)
+	run2.FinishedAt = endAt2.Format(time.RFC3339Nano)
+	run2.Status = "failed"
+
+	runs, err := reader.ListRuns(ctx, task.Org, platform.RunFilter{Task: task.ID})
+	if err != nil {
+		t.Fatal(err)
+	}
+	if len(runs) != 2 {
+		t.Fatalf("expected 2 runs, got: %d", len(runs))
+	}
+
+	if diff := cmp.Diff(runs, []*platform.Run{&run, &run2}); diff != "" {
+		for i, r := range runs {
+			t.Logf("returned run[%d]: %+#v", i, *r)
+		}
+		t.Fatalf("unexpected run2 found: -want/+got: %s", diff)
+	}
 }
 
 func runLogTest(t *testing.T, crf CreateRunStoreFunc, drf DestroyRunStoreFunc) {