chore: add some comments

pull/24376/head
Nga Tran 2021-09-15 14:45:04 -04:00
parent 3486cc8b38
commit 7175488133
4 changed files with 7 additions and 7 deletions

View File

@ -524,7 +524,8 @@ impl InfluxRpcPlanner {
/// The data is sorted on (tag_col1, tag_col2, ...) so that all
/// rows for a particular series (groups where all tags are the
/// same) occur together in the plan
// NGA todo: may need to add delete predicate here to emilimate deleted data at read time
// NGA todo: may need to add delete predicate here to eliminate deleted data at read time
// https://github.com/influxdata/influxdb_iox/issues/2548
pub fn read_filter<D>(&self, database: &D, predicate: Predicate) -> Result<SeriesSetPlans>
where
D: QueryDatabase + 'static,

View File

@ -144,8 +144,8 @@ pub fn persist_chunks(
);
}
// NGA todo: we hit this error if there are rows but they are deleted - todo before merge: open a ticket
// Need to think a way to handle this
// NGA todo: we hit this error if there are rows but they are deleted
// Need to think a way to handle this (https://github.com/influxdata/influxdb_iox/issues/2546)
let to_persist = to_persist.expect("should be rows to persist");
let (new_chunk_id, new_chunk) = partition_write.create_rub_chunk(

View File

@ -2,7 +2,6 @@ use assert_cmd::Command;
use predicates::prelude::*;
use std::time::Duration;
#[ignore]
#[tokio::test]
async fn test_logging() {
Command::cargo_bin("influxdb_iox")

View File

@ -1490,9 +1490,9 @@ async fn test_delete() {
// Delete some data
let table = "cpu";
let start = "0";
let stop = "1200";
let pred = r#"region = "west""#;
let start = "100";
let stop = "120";
let pred = "region = west";
let _del = management_client
.delete(db_name.clone(), table, start, stop, pred)
.await