fix: Add a ByOrgID index to DBRP

This commit adds a new index and migration to the DBRP service for
retrieving all database and retention policy mappings for a single
organization.

This change was required to resolve an invalid assumption of the DBRP
service, which relied on a prefix match of the byOrgAndDatabase kv.Index
when performing search operations by organization ID only.

Closes #20096

dbrp/index.go

@@ -0,0 +1,20 @@
+package dbrp
+
+import (
+	"encoding/json"
+
+	"github.com/influxdata/influxdb/v2"
+	"github.com/influxdata/influxdb/v2/kv"
+)
+
+var (
+	ByOrgIDIndexMapping = kv.NewIndexMapping(bucket, byOrgIDIndexBucket, func(v []byte) ([]byte, error) {
+		var dbrp influxdb.DBRPMappingV2
+		if err := json.Unmarshal(v, &dbrp); err != nil {
+			return nil, err
+		}
+
+		id, _ := dbrp.OrganizationID.Encode()
+		return id, nil
+	})
+)

dbrp/service.go

@@ -35,9 +35,10 @@ import (
 )
 
 var (
-	bucket        = []byte("dbrpv1")
+	bucket             = []byte("dbrpv1")
-	indexBucket   = []byte("dbrpbyorganddbindexv1")
+	indexBucket        = []byte("dbrpbyorganddbindexv1")
-	defaultBucket = []byte("dbrpdefaultv1")
+	byOrgIDIndexBucket = []byte("dbrpbyorgv1")
+	defaultBucket      = []byte("dbrpdefaultv1")
 )
 
 var _ influxdb.DBRPMappingServiceV2 = (*AuthorizedService)(nil)
@@ -48,6 +49,7 @@ type Service struct {
 
 	bucketSvc        influxdb.BucketService
 	byOrgAndDatabase *kv.Index
+	byOrg            *kv.Index
 }
 
 func indexForeignKey(dbrp influxdb.DBRPMappingV2) []byte {
@@ -74,6 +76,7 @@ func NewService(ctx context.Context, bucketSvc influxdb.BucketService, st kv.Sto
 			}
 			return indexForeignKey(dbrp), nil
 		}), kv.WithIndexReadPathEnabled),
+		byOrg: kv.NewIndex(ByOrgIDIndexMapping, kv.WithIndexReadPathEnabled),
 	}
 }
 
@@ -277,17 +280,17 @@ func (s *Service) FindMany(ctx context.Context, filter influxdb.DBRPMappingFilte
 	err := s.store.View(ctx, func(tx kv.Tx) error {
 		// Optimized path, use index.
 		if orgID := filter.OrgID; orgID != nil {
-			// The index performs a prefix search.
+			var (
-			// The foreign key is `orgID + db`.
+				db      = ""
-			// If you want to look by orgID only, just pass orgID as prefix.
+				compKey []byte
-			db := ""
+				index   *kv.Index
-			if filter.Database != nil {
+			)
+			if filter.Database != nil && len(*filter.Database) > 0 {
 				db = *filter.Database
-			}
+				compKey = composeForeignKey(*orgID, db)
-			compKey := composeForeignKey(*orgID, db)
+				index = s.byOrgAndDatabase
-			if len(db) > 0 {
+
-				// Even more optimized, looking for the default given an orgID and database.
+				// Filtering by Org, Database and Default == true
-				// No walking index needed.
 				if def := filter.Default; def != nil && *def {
 					defID, err := s.getDefault(tx, compKey)
 					if kv.IsNotFound(err) {
@@ -307,8 +310,12 @@ func (s *Service) FindMany(ctx context.Context, filter influxdb.DBRPMappingFilte
 					_, err = add(tx)(defID, v)
 					return err
 				}
+			} else {
+				compKey, _ = orgID.Encode()
+				index = s.byOrg
 			}
-			return s.byOrgAndDatabase.Walk(ctx, tx, compKey, add(tx))
+
+			return index.Walk(ctx, tx, compKey, add(tx))
 		}
 		bucket, err := tx.Bucket(bucket)
 		if err != nil {
@@ -359,15 +366,25 @@ func (s *Service) Create(ctx context.Context, dbrp *influxdb.DBRPMappingV2) erro
 		return ErrInvalidDBRPID
 	}
 
+	// OrganizationID has been validated by Validate
+	orgID, _ := dbrp.OrganizationID.Encode()
+
 	return s.store.Update(ctx, func(tx kv.Tx) error {
 		bucket, err := tx.Bucket(bucket)
 		if err != nil {
 			return ErrInternalService(err)
 		}
+
+		// populate indices
 		compKey := indexForeignKey(*dbrp)
 		if err := s.byOrgAndDatabase.Insert(tx, compKey, encodedID); err != nil {
 			return err
 		}
+
+		if err := s.byOrg.Insert(tx, orgID, encodedID); err != nil {
+			return err
+		}
+
 		defSet, err := s.isDefaultSet(tx, compKey)
 		if err != nil {
 			return err
@@ -463,6 +480,12 @@ func (s *Service) Delete(ctx context.Context, orgID, id influxdb.ID) error {
 	if err != nil {
 		return ErrInternalService(err)
 	}
+
+	encodedOrgID, err := id.Encode()
+	if err != nil {
+		return ErrInternalService(err)
+	}
+
 	return s.store.Update(ctx, func(tx kv.Tx) error {
 		bucket, err := tx.Bucket(bucket)
 		if err != nil {
@@ -475,6 +498,9 @@ func (s *Service) Delete(ctx context.Context, orgID, id influxdb.ID) error {
 		if err := s.byOrgAndDatabase.Delete(tx, compKey, encodedID); err != nil {
 			return ErrInternalService(err)
 		}
+		if err := s.byOrg.Delete(tx, encodedOrgID, encodedID); err != nil {
+			return ErrInternalService(err)
+		}
 		// If this was the default, we need to set a new default.
 		var derr error
 		if dbrp.Default {

kv/migration/all/0012_dbrp_by_org_index.go

@@ -0,0 +1,8 @@
+package all
+
+import (
+	"github.com/influxdata/influxdb/v2/dbrp"
+	"github.com/influxdata/influxdb/v2/kv"
+)
+
+var Migration0012_DBRPByOrgIndex = kv.NewIndexMigration(dbrp.ByOrgIDIndexMapping, kv.WithIndexMigrationCleanup)

kv/migration/all/all.go

@@ -29,5 +29,7 @@ var Migrations = [...]migration.Spec{
 	Migration0010_AddIndexTelegrafByOrg,
 	// populate dashboards owner id
 	Migration0011_PopulateDashboardsOwnerId,
+	// Populate the DBRP service ByOrg index
+	Migration0012_DBRPByOrgIndex,
 	// {{ do_not_edit . }}
 }

testing/dbrp_mapping_v2.go

@@ -735,7 +735,7 @@ func FindManyDBRPMappingsV2(
 			fields: DBRPMappingFieldsV2{
 				DBRPMappingsV2: []*influxdb.DBRPMappingV2{
 					{
-						ID:              100,
+						ID:              MustIDBase16("0000000000000100"),
 						Database:        "database",
 						RetentionPolicy: "retention_policyA",
 						Default:         false,
@@ -743,7 +743,7 @@ func FindManyDBRPMappingsV2(
 						BucketID:        MustIDBase16(dbrpBucketAID),
 					},
 					{
-						ID:              200,
+						ID:              MustIDBase16("0000000000000200"),
 						Database:        "database",
 						RetentionPolicy: "retention_policyB",
 						Default:         true,
@@ -751,7 +751,7 @@ func FindManyDBRPMappingsV2(
 						BucketID:        MustIDBase16(dbrpBucketBID),
 					},
 					{
-						ID:              300,
+						ID:              MustIDBase16("0000000000000300"),
 						Database:        "database",
 						RetentionPolicy: "retention_policyB",
 						Default:         true,
@@ -770,7 +770,7 @@ func FindManyDBRPMappingsV2(
 			wants: wants{
 				dbrpMappings: []*influxdb.DBRPMappingV2{
 					{
-						ID:              200,
+						ID:              MustIDBase16("0000000000000200"),
 						Database:        "database",
 						RetentionPolicy: "retention_policyB",
 						Default:         true,