From 6de0c0a5c0ace42029bc939a26b9b932d91651f0 Mon Sep 17 00:00:00 2001 From: Andrew Watkins Date: Tue, 29 Aug 2017 16:11:43 -0700 Subject: [PATCH] Fix inability to add kapacitor from source page The kapacitors array on source was not yet defined. So, I added a default empty array to the kapacitors key off of source. Also, cleaned up some logic regarding the duplication of kapacitor names. --- ui/src/kapacitor/containers/KapacitorPage.js | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ui/src/kapacitor/containers/KapacitorPage.js b/ui/src/kapacitor/containers/KapacitorPage.js index b5f26c5f84..50cb443cdd 100644 --- a/ui/src/kapacitor/containers/KapacitorPage.js +++ b/ui/src/kapacitor/containers/KapacitorPage.js @@ -68,11 +68,18 @@ class KapacitorPage extends Component { handleSubmit(e) { e.preventDefault() - const {addFlashMessage, source, params, router} = this.props + const { + addFlashMessage, + source, + source: {kapacitors = []}, + params, + router, + } = this.props const {kapacitor} = this.state - const kapNames = source.kapacitors.map(k => k.name) - if (kapNames.includes(kapacitor.name)) { + const isNameTaken = kapacitors.some(k => k.name === kapacitor.name) + + if (isNameTaken) { addFlashMessage({ type: 'error', text: `There is already a Kapacitor configuration named "${kapacitor.name}"`,