Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: do not ignore failed persist tasks (#3866) 

I'm seeing some panics in our test bench, but it the ingester happily
continues and thinks it persisted tasks even though it didn't. Let's at
least bail out if a persist task fails.
pull/24376/head
Marco Neumann 2022-02-28 09:30:42 +00:00 committed by GitHub
parent d7bd46f086
commit 6bb18672a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ingester/src/lifecycle.rs
View File

@ -253,7 +253,10 @@ impl LifecycleManager {
if !persist_tasks.is_empty() { if !persist_tasks.is_empty() {
let persists = futures::future::join_all(persist_tasks.into_iter()); let persists = futures::future::join_all(persist_tasks.into_iter());
persists.await; let results = persists.await;
for res in results {
res.expect("not aborted").expect("task finished");
}
// for the sequencers that had data persisted, update their min_unpersisted_sequence_number to // for the sequencers that had data persisted, update their min_unpersisted_sequence_number to
// either the minimum remaining in everything that didn't get persisted, or the highest // either the minimum remaining in everything that didn't get persisted, or the highest