Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

chore: fix spelling and grammar mistakes, remove dead code

gw/edge306/token_hashing
Geoffrey Wossum 2025-02-25 14:24:53 -06:00
parent 80cf2e6cbf
commit 6aa2d1a7fc
No known key found for this signature in database
GPG Key ID: 02E7AAF2176D7846
2 changed files with 3 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
authorization/storage_authorization.go
View File

@ -106,7 +106,7 @@ func (s *Store) transformToken(a *influxdb.Authorization) error {
// code that triggered commit needs access to the raw Token, such as when a
// token is initially created so it can be shown to the user.
// Note that even if a.HashedToken is set, we will regenerate it here. This ensures
// that a.HashedToken will be stored using the currently configured hashing algoirithm.
// that a.HashedToken will be stored using the currently configured hashing algorithm.
if hashedToken, err := s.hasher.Hash(a.Token); err != nil {
return fmt.Errorf("error hashing token: %w", err)
} else {

39
authorization/storage_authorization_test.go
View File

@ -427,8 +427,8 @@ func TestAuthorizationStore_HashingConfigChanges(t *testing.T) {
},
// The following tests are artificial tests intended to check proper operation when both
// Token and HashedToken is set on an update. This should not occur in normal operation because,
// we do not alter tokens like this. However, this is nothing to prevent this so we want to make sure
// Token and HashedToken are set on an update. This should not occur in normal operation because,
// we do not alter tokens like this. However, there is nothing to prevent this so we want to make sure
// it works properly.
{
desc: "set Token and HashedToken with hashing enabled",
@ -485,41 +485,6 @@ func TestAuthorizationStore_HashingConfigChanges(t *testing.T) {
},
hashedTokens: []string{},
},
/*
{
desc: "set Token and HashedToken with hashing re-enabled",
config: testConfig{enabled: true, algo: influxdb2_algo.VariantIdentifierSHA256},
action: func(t *testing.T, ctx context.Context, store *authorization.Store, tx kv.Tx) {
for i := 1; i <= 3; i++ {
token := fmt.Sprintf("Token#%d", i)
auth, err := store.GetAuthorizationByToken(ctx, tx, token)
require.NoError(t, err)
require.Equal(t, auth.Token, token)
require.Empty(t, auth.HashedToken, "only Token should be set from the last test case")
// Set Token and update.
tokenDigest, err := sha256.Hash(token)
require.NoError(t, err)
hashedToken := tokenDigest.Encode()
auth.HashedToken = hashedToken
newAuth, err := store.UpdateAuthorization(ctx, tx, platform.ID(i), auth)
require.NoError(t, err)
// Both newAuth.Token and newAuth.HashedToken should still be set, but only
// HashedToken should be stored and indexed.
require.Equal(t, token, newAuth.Token)
require.Equal(t, hashedToken, newAuth.HashedToken)
}
},
// NOTE: All hashes should be updated to the currently configured algorithm.
exp: []authData{
{ID: platform.ID(1), HashedToken: sha256.MustHash("Token#1").Encode()},
{ID: platform.ID(2), HashedToken: sha256.MustHash("Token#2").Encode()},
{ID: platform.ID(3), HashedToken: sha256.MustHash("Token#3").Encode()},
},
hashedTokens: []string{"Token#1", "Token#2", "Token#3"},
},
*/
}
ctx := context.Background()