From 66395686658c88cd0ec323b52fda040bc03cb723 Mon Sep 17 00:00:00 2001 From: Dom Dwyer Date: Thu, 1 Dec 2022 11:34:25 +0100 Subject: [PATCH] refactor: remove unimplemented!() This lets us keep the existing test coverage for the new impl. --- ingester2/src/buffer_tree/partition.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ingester2/src/buffer_tree/partition.rs b/ingester2/src/buffer_tree/partition.rs index 0847de476d..1eb1fb5069 100644 --- a/ingester2/src/buffer_tree/partition.rs +++ b/ingester2/src/buffer_tree/partition.rs @@ -215,7 +215,11 @@ impl PartitionData { // queriers consider writes in the object store as being strictly after // writes returned from an ingester. - unimplemented!(); + assert!( + self.persisting.is_some(), + "must be a persisting batch when marking complete" + ); + self.persisting = None; } pub(crate) fn partition_id(&self) -> PartitionId {