From a3e750c9fcca211cf528574fa39f75bab5889870 Mon Sep 17 00:00:00 2001
From: Edd Robinson <me@edd.io>
Date: Fri, 22 Oct 2021 11:27:06 +0100
Subject: [PATCH] test: add null column to test

---
 read_buffer/src/chunk.rs | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/read_buffer/src/chunk.rs b/read_buffer/src/chunk.rs
index 94ac209ba4..f6e7df7cb1 100644
--- a/read_buffer/src/chunk.rs
+++ b/read_buffer/src/chunk.rs
@@ -974,6 +974,7 @@ mod test {
                 .field("sketchy_sensor", Int64)
                 .non_null_field("active", Boolean)
                 .field("msg", Utf8)
+                .field("all_null", Utf8)
                 .timestamp()
                 .build()
                 .unwrap();
@@ -997,6 +998,7 @@ mod test {
                     Some("message b"),
                     None,
                 ])),
+                Arc::new(StringArray::from(vec![None, None, None])),
                 Arc::new(TimestampNanosecondArray::from_vec(
                     vec![i, 2 * i, 3 * i],
                     None,
@@ -1058,6 +1060,7 @@ mod test {
         );
         assert_rb_column_equals(&first_row_group, "active", &exp_active_values);
         assert_rb_column_equals(&first_row_group, "msg", &exp_msg_values);
+        assert_rb_column_equals(&first_row_group, "all_null", &Values::String(vec![None]));
         assert_rb_column_equals(&first_row_group, "time", &Values::I64(vec![100])); // first row from first record batch
 
         let second_row_group = itr.next().unwrap();
@@ -1070,8 +1073,16 @@ mod test {
             &exp_sketchy_sensor_values,
         );
         assert_rb_column_equals(&first_row_group, "active", &exp_active_values);
+        assert_rb_column_equals(&first_row_group, "all_null", &Values::String(vec![None]));
         assert_rb_column_equals(&second_row_group, "time", &Values::I64(vec![200])); // first row from second record batch
 
+        // No rows returned when filtering on all_null column
+        let predicate = Predicate::new(vec![BinaryExpr::from(("all_null", "!=", "a string"))]);
+        let mut itr = chunk
+            .read_filter(predicate, Selection::All, vec![])
+            .unwrap();
+        assert!(itr.next().is_none());
+
         // Error when predicate is invalid
         let predicate =
             Predicate::with_time_range(&[BinaryExpr::from(("env", "=", 22.3))], 100, 205);