chore: slim down `criterion` (#5611)

Criterion comes with some extra cargo tooling called `cargo criterion`
which can be used instead of `cargo bench`. The advantage is that we
don't need to compile the entire reporting infrastructure into our
benchmarks. So let's embrace this separation of concerns.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Cargo.lock

@@ -869,7 +869,6 @@ dependencies = [
  "lazy_static",
  "num-traits",
  "oorandom",
- "plotters",
  "rayon",
  "regex",
  "serde",
@@ -3480,34 +3479,6 @@ version = "0.1.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "8b870d8c151b6f2fb93e84a13146138f05d02ed11c7e7c54f8826aaaf7c9f184"
 
-[[package]]
-name = "plotters"
-version = "0.3.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "716b4eeb6c4a1d3ecc956f75b43ec2e8e8ba80026413e70a3f41fd3313d3492b"
-dependencies = [
- "num-traits",
- "plotters-backend",
- "plotters-svg",
- "wasm-bindgen",
- "web-sys",
-]
-
-[[package]]
-name = "plotters-backend"
-version = "0.3.4"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "193228616381fecdc1224c62e96946dfbc73ff4384fba576e052ff8c1bea8142"
-
-[[package]]
-name = "plotters-svg"
-version = "0.3.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f9a81d2759aae1dae668f783c308bc5c8ebd191ff4184aaa1b37f65a6ae5a56f"
-dependencies = [
- "plotters-backend",
-]
-
 [[package]]
 name = "pprof"
 version = "0.10.1"

cache_system/Cargo.toml

@@ -17,7 +17,7 @@ trace = { path = "../trace"}
 workspace-hack = { path = "../workspace-hack"}
 
 [dev-dependencies]
-criterion = "0.4"
+criterion = { version = "0.4", default-features = false, features = ["rayon"]}
 proptest = { version = "1", default_features = false, features = ["std"] }
 rand = "0.8.3"
 

iox_data_generator/Cargo.toml

@@ -26,7 +26,7 @@ tracing-subscriber = "0.3"
 uuid = { version = "1", default_features = false }
 
 [dev-dependencies]
-criterion = "0.4.0"
+criterion = { version = "0.4", default-features = false, features = ["rayon"]}
 test_helpers = { path = "../test_helpers" }
 
 [[bench]]

mutable_batch_lp/Cargo.toml

@@ -15,7 +15,7 @@ workspace-hack = { path = "../workspace-hack"}
 [dev-dependencies]
 arrow_util = { path = "../arrow_util" }
 assert_matches = "1.5.0"
-criterion = "0.4"
+criterion = { version = "0.4", default-features = false, features = ["rayon"]}
 
 [[bench]]
 name = "parse_lp"

mutable_batch_tests/Cargo.toml

@@ -15,7 +15,7 @@ prost = "0.11"
 
 [dev-dependencies]
 bytes = "1.2"
-criterion = "0.4"
+criterion = { version = "0.4", default-features = false, features = ["rayon"]}
 
 [[bench]]
 name = "write_lp"

packers/Cargo.toml

@@ -13,7 +13,7 @@ parquet = "21.0.0"
 workspace-hack = { path = "../workspace-hack"}
 
 [dev-dependencies] # In alphabetical order
-criterion = "0.4.0"
+criterion = { version = "0.4", default-features = false, features = ["rayon"]}
 rand = "0.8.3"
 
 [[bench]]

read_buffer/Cargo.toml

@@ -28,7 +28,7 @@ schema = { path = "../schema" }
 workspace-hack = { path = "../workspace-hack"}
 
 [dev-dependencies] # In alphabetical order
-criterion = "0.4.0"
+criterion = { version = "0.4", default-features = false, features = ["rayon"]}
 packers = { path = "../packers" }
 proptest = { version = "1.0.0", default_features = false, features = ["std"] }
 rand = "0.8.3"

router/Cargo.toml

@@ -40,7 +40,7 @@ write_summary = { path = "../write_summary" }
 
 [dev-dependencies]
 assert_matches = "1.5"
-criterion = { version = "0.4.0", features = ["async_tokio", "html_reports"] }
+criterion = { version = "0.4", default-features = false, features = ["async_tokio", "rayon"]}
 once_cell = "1"
 paste = "1.0.9"
 pretty_assertions = "1.3.0"

sharder/Cargo.toml

@@ -11,7 +11,7 @@ siphasher = "0.3"
 workspace-hack = { path = "../workspace-hack"}
 
 [dev-dependencies]
-criterion = { version = "0.4.0", features = ["async_tokio", "html_reports"] }
+criterion = { version = "0.4", default-features = false, features = ["async_tokio", "rayon"]}
 hashbrown = "0.12"
 mutable_batch_lp = { path = "../mutable_batch_lp" }
 rand = "0.8.3"