From 59282bce6ef954a3e77ed5960263714f0e8d7af0 Mon Sep 17 00:00:00 2001 From: Edd Robinson Date: Wed, 21 Apr 2021 22:51:56 +0100 Subject: [PATCH] refactor: swap existing metrics for THE NEW WAY --- src/influxdb_ioxd.rs | 1 + src/influxdb_ioxd/http.rs | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/influxdb_ioxd.rs b/src/influxdb_ioxd.rs index 1cd62ca511..5037721a11 100644 --- a/src/influxdb_ioxd.rs +++ b/src/influxdb_ioxd.rs @@ -1,6 +1,7 @@ use crate::commands::run::{Config, ObjectStore as ObjStoreOpt}; use futures::{future::FusedFuture, pin_mut, FutureExt}; use hyper::server::conn::AddrIncoming; +use metrics::MetricRegistry; use object_store::{ self, aws::AmazonS3, azure::MicrosoftAzure, gcp::GoogleCloudStorage, ObjectStore, }; diff --git a/src/influxdb_ioxd/http.rs b/src/influxdb_ioxd/http.rs index d8bc8efa51..c87a5f7f1f 100644 --- a/src/influxdb_ioxd/http.rs +++ b/src/influxdb_ioxd/http.rs @@ -423,6 +423,9 @@ where let path = req.uri().path().to_string(); let server = Arc::clone(&req.data::>>().expect("server state")); + // TODO - metrics. Implement a macro/something that will catch all the + // early returns. + // TODO(edd): figure out best way of catching all errors in this observation. let obs = server.metrics.http_requests.observation(); // instrument request