From 7fee10fed93f576cf57469e5a63674de20f9a940 Mon Sep 17 00:00:00 2001 From: Alex P Date: Wed, 3 May 2017 15:43:38 -0700 Subject: [PATCH 1/3] Make overlay technology full screen MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit No reason why this can’t or shouldn’t be done, it is a modal after all --- ui/src/style/layout/overlay.scss | 23 ++++++++++++++++++++++ ui/src/style/layout/page.scss | 2 -- ui/src/style/pages/overlay-technology.scss | 1 - 3 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 ui/src/style/layout/overlay.scss diff --git a/ui/src/style/layout/overlay.scss b/ui/src/style/layout/overlay.scss new file mode 100644 index 0000000000..a736026a00 --- /dev/null +++ b/ui/src/style/layout/overlay.scss @@ -0,0 +1,23 @@ +/* + Manages Overlays + ---------------------------------------------- +*/ + +.page, .sidebar { + position: relative; +} +.page { + z-index: 2; +} +.sidebar { + z-index: 1; + + // Ensures that sidebar menus appear above the rest of the app on hover + &:hover {z-index: 2;} + &:hover + .page {z-index: 1;} +} + +// Make Overlay Technology full screen +.overlay-technology { + left: -($sidebar-width) !important; +} \ No newline at end of file diff --git a/ui/src/style/layout/page.scss b/ui/src/style/layout/page.scss index 0034b3e96a..e39b99eae6 100644 --- a/ui/src/style/layout/page.scss +++ b/ui/src/style/layout/page.scss @@ -13,9 +13,7 @@ color: $g17-whisper; } .page { - position: relative; flex-grow: 1; - overflow: hidden; } .page-contents { position: absolute; diff --git a/ui/src/style/pages/overlay-technology.scss b/ui/src/style/pages/overlay-technology.scss index 912b236f37..b5c952f6dc 100644 --- a/ui/src/style/pages/overlay-technology.scss +++ b/ui/src/style/pages/overlay-technology.scss @@ -11,7 +11,6 @@ $overlay-z: 100; position: absolute; top: 0; bottom: 0; - left: 0; right: 0; z-index: $overlay-z; padding: 0 30px; From 2e485ffa48ebefe475b1723b7f6f92e81cf905f0 Mon Sep 17 00:00:00 2001 From: Alex P Date: Wed, 3 May 2017 15:53:07 -0700 Subject: [PATCH 2/3] Update the changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7bc486c5ff..8c2ea337ab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ 1. [#1365](https://github.com/influxdata/chronograf/pull/1365): Show red indicator on Hosts Page for an offline host 1. [#1373](https://github.com/influxdata/chronograf/pull/1373): Re-address dashboard cell stacking contexts 1. [#602](https://github.com/influxdata/chronograf/pull/602): Normalize terminology in app + 1. [#1392](https://github.com/influxdata/chronograf/pull/1392): Overlays are now full screen ## v1.2.0-beta10 [2017-04-28] From 096cf1592bd8c3e6b75a9481f1347a324907a26e Mon Sep 17 00:00:00 2001 From: Alex P Date: Thu, 4 May 2017 12:32:32 -0700 Subject: [PATCH 3/3] Forgot this piece --- ui/src/style/chronograf.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/src/style/chronograf.scss b/ui/src/style/chronograf.scss index efdee037a7..b57ca46946 100644 --- a/ui/src/style/chronograf.scss +++ b/ui/src/style/chronograf.scss @@ -22,6 +22,7 @@ @import 'layout/page'; @import 'layout/page-header'; @import 'layout/sidebar'; +@import 'layout/overlay'; // Components @import 'components/confirm-buttons';