feat: don't use opentelemetry async trace exporter (#2576)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
pull/24376/head
Raphael Taylor-Davies 2021-09-19 14:20:13 +01:00 committed by GitHub
parent 4382bc0b71
commit 5298543321
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 6 deletions

3
Cargo.lock generated
View File

@ -2656,8 +2656,6 @@ dependencies = [
"pin-project",
"rand 0.8.4",
"thiserror",
"tokio",
"tokio-stream",
]
[[package]]
@ -2672,7 +2670,6 @@ dependencies = [
"opentelemetry-semantic-conventions",
"thiserror",
"thrift",
"tokio",
]
[[package]]

View File

@ -11,8 +11,8 @@ async-trait = "0.1"
chrono = { version = "0.4" }
futures = "0.3"
observability_deps = { path = "../observability_deps" }
opentelemetry = { version = "0.16", features = ["rt-tokio"] }
opentelemetry-jaeger = { version = "0.15", optional = true, features = ["rt-tokio"] }
opentelemetry = { version = "0.16" }
opentelemetry-jaeger = { version = "0.15", optional = true }
snafu = "0.6"
structopt = { version = "0.3.23" }
tokio = { version = "1.11", features = ["macros", "time", "sync", "rt"] }

View File

@ -124,7 +124,7 @@ fn jaeger_exporter(config: &TracingConfig) -> Result<Arc<dyn TraceCollector>> {
let exporter = opentelemetry_jaeger::new_pipeline()
.with_agent_endpoint(agent_endpoint)
.with_service_name(&config.traces_exporter_jaeger_service_name)
.init_async_exporter(opentelemetry::runtime::Tokio {})
.init_sync_exporter()
.map_err(|source| Error::TraceExporter { source })?;
Ok(Arc::new(otel::OtelExporter::new(exporter)))