Merge pull request #3457 from influxdata/bugfix/data-explorer-error

Fix Data Explorer Status Reporting again
pull/10616/head
Deniz Kusefoglu 2018-05-15 11:42:47 -07:00 committed by GitHub
commit 4b2418a2f9
5 changed files with 18 additions and 5 deletions

View File

@ -37,6 +37,7 @@
1. [#3402](https://github.com/influxdata/chronograf/pull/3402): Fix missing icons when using basepath 1. [#3402](https://github.com/influxdata/chronograf/pull/3402): Fix missing icons when using basepath
1. [#3412](https://github.com/influxdata/chronograf/pull/3412): Limit max-width of TICKScript editor. 1. [#3412](https://github.com/influxdata/chronograf/pull/3412): Limit max-width of TICKScript editor.
1. [#3166](https://github.com/influxdata/chronograf/pull/3166): Fixes naming of new TICKScripts 1. [#3166](https://github.com/influxdata/chronograf/pull/3166): Fixes naming of new TICKScripts
1. [#3449](https://github.com/influxdata/chronograf/pull/3449): Fixes data explorer query error reporting regression
1. [#3453](https://github.com/influxdata/chronograf/pull/3453): Fix Kapacitor Logs fetch regression 1. [#3453](https://github.com/influxdata/chronograf/pull/3453): Fix Kapacitor Logs fetch regression
## v1.4.4.1 [2018-04-16] ## v1.4.4.1 [2018-04-16]

View File

@ -225,7 +225,7 @@ class ChronoTable extends PureComponent<Props, State> {
try { try {
const {results} = await fetchTimeSeriesAsync({ const {results} = await fetchTimeSeriesAsync({
source: this.source, source: this.source,
query: query.text, query,
tempVars: TEMPLATES, tempVars: TEMPLATES,
}) })

View File

@ -51,14 +51,24 @@ export const handleError = (error, query, editQueryStatus) => {
}) })
} }
interface Query {
host: string | string[]
text: string
id: string
database?: string
db?: string
rp?: string
}
interface Payload { interface Payload {
source: string source: string
query: string query: Query
tempVars: any[] tempVars: any[]
db?: string db?: string
rp?: string rp?: string
resolution?: number resolution?: number
} }
export const fetchTimeSeriesAsync = async ( export const fetchTimeSeriesAsync = async (
{source, db, rp, query, tempVars, resolution}: Payload, {source, db, rp, query, tempVars, resolution}: Payload,
editQueryStatus = noop editQueryStatus = noop
@ -69,7 +79,7 @@ export const fetchTimeSeriesAsync = async (
source, source,
db, db,
rp, rp,
query, query: query.text,
tempVars, tempVars,
resolution, resolution,
}) })

View File

@ -29,6 +29,7 @@ interface Query {
database: string database: string
db: string db: string
rp: string rp: string
id: string
} }
const parseSource = source => { const parseSource = source => {
@ -46,7 +47,7 @@ export const fetchTimeSeries = async (
editQueryStatus: () => any editQueryStatus: () => any
) => { ) => {
const timeSeriesPromises = queries.map(query => { const timeSeriesPromises = queries.map(query => {
const {host, database, rp, text} = query const {host, database, rp} = query
// the key `database` was used upstream in HostPage.js, and since as of this writing // the key `database` was used upstream in HostPage.js, and since as of this writing
// the codebase has not been fully converted to TypeScript, it's not clear where else // the codebase has not been fully converted to TypeScript, it's not clear where else
// it may be used, but this slight modification is intended to allow for the use of // it may be used, but this slight modification is intended to allow for the use of
@ -72,7 +73,7 @@ export const fetchTimeSeries = async (
const tempVars = removeUnselectedTemplateValues(templatesWithIntervalVals) const tempVars = removeUnselectedTemplateValues(templatesWithIntervalVals)
const source = parseSource(host) const source = parseSource(host)
const payload = {source, db, rp, query: text, tempVars, resolution} const payload = {source, db, rp, query, tempVars, resolution}
return fetchTimeSeriesAsync(payload, editQueryStatus) return fetchTimeSeriesAsync(payload, editQueryStatus)
}) })

View File

@ -18,6 +18,7 @@ interface Query {
database: string database: string
db: string db: string
rp: string rp: string
id: string
} }
interface TemplateQuery { interface TemplateQuery {