From 438e0725bdebcc511bac782e6f7e7e52ca0aa354 Mon Sep 17 00:00:00 2001
From: Christopher Henn <chris@chrishenn.net>
Date: Wed, 20 Jun 2018 11:25:12 -0700
Subject: [PATCH] Refactor TemplateControlBar test

---
 .../components/TemplateControlBar.test.tsx    | 59 ++++++++-----------
 1 file changed, 25 insertions(+), 34 deletions(-)

diff --git a/ui/test/tempVars/components/TemplateControlBar.test.tsx b/ui/test/tempVars/components/TemplateControlBar.test.tsx
index 6a0c62be4b..c3295221ae 100644
--- a/ui/test/tempVars/components/TemplateControlBar.test.tsx
+++ b/ui/test/tempVars/components/TemplateControlBar.test.tsx
@@ -8,8 +8,18 @@ import {source} from 'test/resources'
 
 const defaultProps = {
   isOpen: true,
-  templates: [
-    {
+  templates: [],
+  meRole: 'EDITOR',
+  isUsingAuth: true,
+  onSelectTemplate: () => {},
+  onSaveTemplates: () => {},
+  onCreateTemplateVariable: () => {},
+  source,
+}
+
+describe('TemplateControlBar', () => {
+  it('renders component with variables', () => {
+    const template = {
       id: '000',
       tempVar: ':alpha:',
       label: '',
@@ -26,42 +36,23 @@ const defaultProps = {
           selected: false,
         },
       ],
-    },
-  ],
-  meRole: 'EDITOR',
-  isUsingAuth: true,
-  onOpenTemplateManager: () => {},
-  onSelectTemplate: () => {},
-  onSaveTemplates: () => {},
-  onCreateTemplateVariable: () => {},
-  source,
-}
+    }
+    const props = {...defaultProps, templates: [template]}
+    const wrapper = shallow(<TemplateControlBar {...props} />)
 
-const setup = (override = {}) => {
-  const props = {...defaultProps, ...override}
-  const wrapper = shallow(<TemplateControlBar {...props} />)
+    const dropdown = wrapper.find(TemplateControlDropdown)
+    expect(dropdown.exists()).toBe(true)
+  })
 
-  return {wrapper, props}
-}
+  it('renders component without variables', () => {
+    const props = {...defaultProps}
+    const wrapper = shallow(<TemplateControlBar {...props} />)
 
-describe('Dashboard.TemplateControlBar', () => {
-  describe('rendering', () => {
-    it('renders component with variables', () => {
-      const {wrapper} = setup()
+    const emptyState = wrapper.find({'data-test': 'empty-state'})
 
-      const dropdown = wrapper.find(TemplateControlDropdown)
-      expect(dropdown.exists()).toBe(true)
-    })
+    const dropdown = wrapper.find(TemplateControlDropdown)
 
-    it('renders component without variables', () => {
-      const {wrapper} = setup({...defaultProps, templates: []})
-
-      const emptyState = wrapper.find({'data-test': 'empty-state'})
-
-      const dropdown = wrapper.find(TemplateControlDropdown)
-
-      expect(dropdown.exists()).toBe(false)
-      expect(emptyState.exists()).toBe(true)
-    })
+    expect(dropdown.exists()).toBe(false)
+    expect(emptyState.exists()).toBe(true)
   })
 })