Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: fix Rust 2021 compat warning 

This fixes the following warning:

```text
warning: panic message is not a string literal
   --> mutable_buffer/src/table.rs:591:13
    |
591 |             format!("didn't match returned error: {:?}", response)
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(non_fmt_panic)]` on by default
    = note: this is no longer accepted in Rust 2021
    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
help: remove the `format!(..)` macro call
    |
591 |             "didn't match returned error: {:?}", response
    |            --                                           --
```
pull/24376/head
Marco Neumann 2021-04-19 13:51:06 +02:00
parent fd0da7e74a
commit 40decd0154
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
mutable_buffer/src/table.rs
View File

@ -588,7 +588,8 @@ mod tests {
actual_column_type,
..
} if expected_column_type == "tag" && actual_column_type == "String"),
format!("didn't match returned error: {:?}", response)
"didn't match returned error: {:?}",
response
);
let lp = "foo iv=1u 1";
@ -612,7 +613,8 @@ mod tests {
.unwrap();
assert!(
matches!(&response, Error::InternalColumnTypeMismatch {expected_column_type, actual_column_type, ..} if expected_column_type == "i64" && actual_column_type == "u64"),
format!("didn't match returned error: {:?}", response)
"didn't match returned error: {:?}",
response
);
let lp = "foo fv=1i 1";
@ -636,7 +638,8 @@ mod tests {
.unwrap();
assert!(
matches!(&response, Error::InternalColumnTypeMismatch {expected_column_type, actual_column_type, ..} if expected_column_type == "f64" && actual_column_type == "i64"),
format!("didn't match returned error: {:?}", response)
"didn't match returned error: {:?}",
response
);
let lp = "foo bv=1 1";
@ -660,7 +663,8 @@ mod tests {
.unwrap();
assert!(
matches!(&response, Error::InternalColumnTypeMismatch {expected_column_type, actual_column_type, ..} if expected_column_type == "bool" && actual_column_type == "f64"),
format!("didn't match returned error: {:?}", response)
"didn't match returned error: {:?}",
response
);
let lp = "foo sv=true 1";
@ -684,7 +688,8 @@ mod tests {
.unwrap();
assert!(
matches!(&response, Error::InternalColumnTypeMismatch {expected_column_type, actual_column_type, ..} if expected_column_type == "String" && actual_column_type == "bool"),
format!("didn't match returned error: {:?}", response)
"didn't match returned error: {:?}",
response
);
}