Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add test-ids to create resource dropdown items

pull/13801/head
Deniz Kusefoglu 2019-05-06 14:07:35 -07:00
parent 3579b02f80
commit 3ebc2fd453
5 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ui/cypress/e2e/dashboardsIndex.test.ts
View File

@ -24,7 +24,7 @@ describe('Dashboards', () => {
.contains('Create') .contains('Create')
.click() .click()
cy.getByTestID('dropdown--item New Dashboard').click() cy.getByTestID('dropdown--item new').click()
cy.fixture('routes').then(({orgs}) => { cy.fixture('routes').then(({orgs}) => {
cy.get<Organization>('@org').then(({id}) => { cy.get<Organization>('@org').then(({id}) => {
@ -40,7 +40,7 @@ describe('Dashboards', () => {
.contains('Create') .contains('Create')
.click() .click()
cy.getByTestID('dropdown--item New Dashboard').click() cy.getByTestID('dropdown--item new').click()
cy.fixture('routes').then(({orgs}) => { cy.fixture('routes').then(({orgs}) => {
cy.get<Organization>('@org').then(({id}) => { cy.get<Organization>('@org').then(({id}) => {
@ -61,7 +61,7 @@ describe('Dashboards', () => {
.contains('Create') .contains('Create')
.click() .click()
cy.getByTestID('dropdown--item From a Template').click() cy.getByTestID('dropdown--item template').click()
cy.getByTestID('template--Bashboard-Template').click() cy.getByTestID('template--Bashboard-Template').click()

4
ui/cypress/e2e/tasks.test.ts
View File

@ -22,7 +22,7 @@ describe('Tasks', () => {
cy.contains('Create').click() cy.contains('Create').click()
}) })
cy.getByTestID('dropdown--item New Task').click() cy.getByTestID('dropdown--item new').click()
cy.getByInputName('name').type(taskName) cy.getByInputName('name').type(taskName)
cy.getByInputName('interval').type('24h') cy.getByInputName('interval').type('24h')
@ -110,7 +110,7 @@ describe('Tasks', () => {
cy.contains('Create').click() cy.contains('Create').click()
}) })
cy.getByTestID('dropdown--item New Task').click() cy.getByTestID('dropdown--item new').click()
cy.getByInputName('name').type('🦄ask') cy.getByInputName('name').type('🦄ask')
cy.getByInputName('interval').type('24h') cy.getByInputName('interval').type('24h')

2
ui/cypress/e2e/variables.test.ts
View File

@ -15,7 +15,7 @@ describe('Variables', () => {
cy.contains('Create').click() cy.contains('Create').click()
}) })
cy.getByTestID('dropdown--item New Variable').click() cy.getByTestID('dropdown--item new').click()
cy.getByInputName('name').type('Little Variable') cy.getByInputName('name').type('Little Variable')
cy.getByTestID('flux-editor').within(() => { cy.getByTestID('flux-editor').within(() => {

1
ui/src/dashboards/components/dashboard_index/Table.tsx
View File

@ -133,6 +133,7 @@ class DashboardsTable extends PureComponent<Props, State> {
onSelectImport={onImportDashboard} onSelectImport={onImportDashboard}
onSelectTemplate={this.summonImportFromTemplateOverlay} onSelectTemplate={this.summonImportFromTemplateOverlay}
resourceName="Dashboard" resourceName="Dashboard"
canImportFromTemplate={true}
/> />
</EmptyState> </EmptyState>
) )

15
ui/src/shared/components/AddResourceDropdown.tsx
View File

@ -58,10 +58,20 @@ export default class AddResourceDropdown extends PureComponent<Props> {
const templateOption = this.templateOption const templateOption = this.templateOption
const items = [ const items = [
<Dropdown.Item id={newOption} key={newOption} value={newOption}> <Dropdown.Item
id={newOption}
key={newOption}
value={newOption}
testID="dropdown--item new"
>
{newOption} {newOption}
</Dropdown.Item>, </Dropdown.Item>,
<Dropdown.Item id={importOption} key={importOption} value={importOption}> <Dropdown.Item
id={importOption}
key={importOption}
value={importOption}
testID="dropdown--item import"
>
{importOption} {importOption}
</Dropdown.Item>, </Dropdown.Item>,
] ]
@ -72,6 +82,7 @@ export default class AddResourceDropdown extends PureComponent<Props> {
id={templateOption} id={templateOption}
key={templateOption} key={templateOption}
value={templateOption} value={templateOption}
testID="dropdown--item template"
> >
{templateOption} {templateOption}
</Dropdown.Item> </Dropdown.Item>