Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

feat(persist): Do not capture partition ID for hot persist metric 

Capturing this information has unbounded cardinality and is not
worth the performance and operational implications.
pull/24376/head
Fraser Savage 2023-03-23 11:33:17 +00:00
parent 3955b89e5f
commit 3d545369ae
No known key found for this signature in database
GPG Key ID: DE47C33CE8C5C446
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ingester2/src/persist/hot_partitions.rs
View File

@ -1,6 +1,5 @@
use std::{fmt::Debug, sync::Arc}; use std::{fmt::Debug, sync::Arc};
use metric::U64Counter;
use observability_deps::tracing::info; use observability_deps::tracing::info;
use parking_lot::{Mutex, MutexGuard}; use parking_lot::{Mutex, MutexGuard};
@ -16,7 +15,7 @@ pub(crate) struct HotPartitionPersister<P> {
max_estimated_persist_cost: usize, max_estimated_persist_cost: usize,
/// A metric tracking the number of partitions persisted as "hot partitions". /// A metric tracking the number of partitions persisted as "hot partitions".
persist_count: metric::Metric<U64Counter>, persist_count: metric::U64Counter,
} }
impl<P> HotPartitionPersister<P> impl<P> HotPartitionPersister<P>
@ -29,10 +28,12 @@ where
metrics: &metric::Registry, metrics: &metric::Registry,
) -> Self { ) -> Self {
let persist_count = metrics let persist_count = metrics
.register_metric::<U64Counter>( .register_metric::<metric::U64Counter>(
"ingester_persist_hot_partition_enqueue_count", "ingester_persist_hot_partition_enqueue_count",
"number of times persistence of a partition has been triggered because the persist cost exceeded the pre-configured limit", "number of times persistence of a partition has been triggered \
); because the persist cost exceeded the pre-configured limit",
)
.recorder(&[]);
Self { Self {
persist_handle, persist_handle,
max_estimated_persist_cost, max_estimated_persist_cost,
@ -47,9 +48,8 @@ where
partition: Arc<Mutex<PartitionData>>, partition: Arc<Mutex<PartitionData>>,
mut guard: MutexGuard<'_, PartitionData>, mut guard: MutexGuard<'_, PartitionData>,
) { ) {
let partition_id = guard.partition_id().get();
info!( info!(
partition_id = partition_id, partition_id = guard.partition_id().get(),
cost_estimate, "marking hot partition for persistence" cost_estimate, "marking hot partition for persistence"
); );
@ -65,9 +65,7 @@ where
persist_handle.enqueue(partition, data).await; persist_handle.enqueue(partition, data).await;
}); });
// Update any exported metrics. // Update any exported metrics.
let attributes = self.persist_count.inc(1);
metric::Attributes::from([("partition_id", format!("{partition_id}").into())]);
self.persist_count.recorder(attributes).inc(1);
} }
} }