fix(ui): prevent visualization crash in DE

2019-06-10 10:22:30 -07:00 · 2019-06-10 10:22:30 -07:00 · 23e6c7bf26
parent 49c243186b
commit 23e6c7bf26
1 changed files with 8 additions and 5 deletions
--- a/ui/src/shared/utils/useVisDomainSettings.ts
+++ b/ui/src/shared/utils/useVisDomainSettings.ts
@ -16,12 +16,15 @@ import {extent} from 'src/shared/utils/vis'
 */
 export const useVisDomainSettings = (
  storedDomain: [number, number],
-  data: NumericColumnData = []
+  data: NumericColumnData
 ) => {
-  const initialDomain = useMemo(
-    () => (storedDomain ? storedDomain : extent(data as number[])),
-    [storedDomain, data]
-  )
+  const initialDomain = useMemo(() => {
+    if (storedDomain) {
+      return storedDomain
+    }
+
+    return extent((data as number[]) || [])
+  }, [storedDomain, data])

  const [domain, setDomain] = useOneWayState(initialDomain)
  const resetDomain = () => setDomain(initialDomain)