refactor: appease clippy gods

server/src/config.rs

@@ -8,7 +8,6 @@ use data_types::{
     DatabaseName,
 };
 use object_store::path::ObjectStorePath;
-use read_buffer::Database as ReadBufferDb;
 
 /// This module contains code for managing the configuration of the server.
 use crate::{db::Db, Error, JobRegistry, Result};

server/src/db.rs

@@ -386,7 +386,7 @@ impl Db {
         let table_stats = mb_chunk.table_summaries();
 
         // create a new read buffer chunk.
-        let mut rb_chunk = ReadBufferChunk::new(chunk_id);
+        let rb_chunk = ReadBufferChunk::new(chunk_id);
 
         // load tables into the new chunk one by one.
         for stats in table_stats {

server/src/db/chunk.rs

@@ -77,7 +77,6 @@ impl DBChunk {
     /// Create a DBChunk snapshot of the catalog chunk
     pub fn snapshot(chunk: &super::catalog::chunk::Chunk) -> Arc<Self> {
         let partition_key = Arc::new(chunk.key().to_string());
-        let chunk_id = chunk.id();
 
         use super::catalog::chunk::ChunkState;
 
@@ -239,10 +238,7 @@ impl PartitionChunk for DBChunk {
                     }
                 }
             }
-            Self::ReadBuffer {
-                chunk,
-                partition_key,
-            } => {
+            Self::ReadBuffer { chunk, .. } => {
                 // If not supported, ReadBuffer can't answer with
                 // metadata only
                 let rb_predicate = match to_read_buffer_predicate(&predicate) {
@@ -292,7 +288,6 @@ impl PartitionChunk for DBChunk {
                 // back
                 let needs_sort = matches!(selection, Selection::All);
 
-                let predicate = read_buffer::Predicate::default();
                 // Get the expected output schema for the read_filter operation
                 let mut schema = chunk
                     .read_filter_table_schema(table_name, selection)
@@ -421,10 +416,7 @@ impl PartitionChunk for DBChunk {
                     .column_names(table_name, &chunk_predicate, columns)
                     .context(MutableBufferChunk)
             }
-            Self::ReadBuffer {
-                chunk,
-                partition_key,
-            } => {
+            Self::ReadBuffer { chunk, .. } => {
                 let rb_predicate = match to_read_buffer_predicate(&predicate) {
                     Ok(rb_predicate) => rb_predicate,
                     Err(e) => {

server/src/snapshot.rs

@@ -272,7 +272,6 @@ mod tests {
         db::{DBChunk, Db},
         JobRegistry,
     };
-    use read_buffer::Database as ReadBufferDb;
 
     use super::*;
     use data_types::database_rules::DatabaseRules;