From 1dc54f403ebd5e93507b99a5f4fde58c4211f11e Mon Sep 17 00:00:00 2001
From: Alex Boatwright <drdelambre@gmail.com>
Date: Fri, 12 Jun 2020 15:06:19 -0700
Subject: [PATCH] feat: button order (#18492)

Co-authored-by: drdelambre <drdelambre>
---
 ui/src/notebooks/components/AddButtons.tsx  | 50 +++++++++++++--------
 ui/src/notebooks/index.ts                   |  2 +
 ui/src/notebooks/pipes/Query/index.ts       |  1 +
 ui/src/notebooks/pipes/Spotify/editor.tsx   | 29 ++++++++++++
 ui/src/notebooks/pipes/Spotify/embedded.tsx | 29 ++++++++++++
 ui/src/notebooks/pipes/Spotify/index.ts     | 15 +++++++
 ui/src/notebooks/pipes/Spotify/style.scss   | 10 +++++
 ui/src/notebooks/pipes/Spotify/view.tsx     | 38 ++++++++++++++++
 8 files changed, 155 insertions(+), 19 deletions(-)
 create mode 100644 ui/src/notebooks/pipes/Spotify/editor.tsx
 create mode 100644 ui/src/notebooks/pipes/Spotify/embedded.tsx
 create mode 100644 ui/src/notebooks/pipes/Spotify/index.ts
 create mode 100644 ui/src/notebooks/pipes/Spotify/style.scss
 create mode 100644 ui/src/notebooks/pipes/Spotify/view.tsx

diff --git a/ui/src/notebooks/components/AddButtons.tsx b/ui/src/notebooks/components/AddButtons.tsx
index 56705913ad..b462a7877a 100644
--- a/ui/src/notebooks/components/AddButtons.tsx
+++ b/ui/src/notebooks/components/AddButtons.tsx
@@ -11,25 +11,37 @@ import {PIPE_DEFINITIONS} from 'src/notebooks'
 const AddButtons: FC = () => {
   const {addPipe} = useContext(NotebookContext)
 
-  const pipes = Object.entries(PIPE_DEFINITIONS).map(([type, def]) => {
-    return (
-      <Button
-        key={def.type}
-        text={def.button}
-        onClick={() => {
-          let data = def.initial
-          if (typeof data === 'function') {
-            data = data()
-          }
-          addPipe({
-            ...data,
-            type,
-          })
-        }}
-        color={ComponentColor.Secondary}
-      />
-    )
-  })
+  const pipes = Object.entries(PIPE_DEFINITIONS)
+    .filter(([_, def]) => !def.disabled)
+    .sort((a, b) => {
+      const aPriority = a[1].priority || 0
+      const bPriority = b[1].priority || 0
+
+      if (aPriority === bPriority) {
+        return a[1].button.localeCompare(b[1].button)
+      }
+
+      return bPriority - aPriority
+    })
+    .map(([type, def]) => {
+      return (
+        <Button
+          key={def.type}
+          text={def.button}
+          onClick={() => {
+            let data = def.initial
+            if (typeof data === 'function') {
+              data = data()
+            }
+            addPipe({
+              ...data,
+              type,
+            })
+          }}
+          color={ComponentColor.Secondary}
+        />
+      )
+    })
 
   return <>{pipes}</>
 }
diff --git a/ui/src/notebooks/index.ts b/ui/src/notebooks/index.ts
index 099d56ca2e..64581c3052 100644
--- a/ui/src/notebooks/index.ts
+++ b/ui/src/notebooks/index.ts
@@ -26,6 +26,8 @@ export interface PipeProp {
 // on the page.
 export interface TypeRegistration {
   type: string // a unique string that identifies a pipe
+  priority?: number // 0 is lowest priority, equal priorities revert to string comparison
+  disabled?: boolean // if you should show it or not
   component: FunctionComponent<PipeProp> | ComponentClass<PipeProp> // the view component for rendering the interface
   button: string // a human readable string for appending the type
   initial: any // the default state for an add
diff --git a/ui/src/notebooks/pipes/Query/index.ts b/ui/src/notebooks/pipes/Query/index.ts
index 6894ffe600..56ab886213 100644
--- a/ui/src/notebooks/pipes/Query/index.ts
+++ b/ui/src/notebooks/pipes/Query/index.ts
@@ -4,6 +4,7 @@ import './style.scss'
 
 register({
   type: 'query',
+  priority: 1,
   component: View,
   button: 'Custom Script',
   initial: {
diff --git a/ui/src/notebooks/pipes/Spotify/editor.tsx b/ui/src/notebooks/pipes/Spotify/editor.tsx
new file mode 100644
index 0000000000..9628f99f1a
--- /dev/null
+++ b/ui/src/notebooks/pipes/Spotify/editor.tsx
@@ -0,0 +1,29 @@
+import React, {FC} from 'react'
+import {Input} from '@influxdata/clockface'
+
+import {PipeData} from 'src/notebooks'
+
+interface Props {
+  data: PipeData
+  onUpdate: (data: PipeData) => void
+  visible: boolean
+}
+
+const Editor: FC<Props> = ({data, onUpdate, visible}) => {
+  const update = evt => {
+    onUpdate(evt.target.value)
+  }
+
+  if (!visible) {
+    return null
+  }
+
+  return (
+    <div className="notebook-spotify--editor">
+      <label>Spotify URI</label>
+      <Input value={data.uri} onChange={update} />
+    </div>
+  )
+}
+
+export default Editor
diff --git a/ui/src/notebooks/pipes/Spotify/embedded.tsx b/ui/src/notebooks/pipes/Spotify/embedded.tsx
new file mode 100644
index 0000000000..594117542b
--- /dev/null
+++ b/ui/src/notebooks/pipes/Spotify/embedded.tsx
@@ -0,0 +1,29 @@
+import React, {FC, useMemo} from 'react'
+
+interface Props {
+  uri: string
+  visible: boolean
+}
+
+const Embedded: FC<Props> = ({uri, visible}) => {
+  const parts = uri.split(':')
+
+  if (!visible) {
+    return null
+  }
+
+  return useMemo(
+    () => (
+      <iframe
+        src={`https://open.spotify.com/embed/${parts[1]}/${parts[2]}`}
+        width="600"
+        height="80"
+        frameBorder="0"
+        allow="encrypted-media"
+      />
+    ),
+    [uri]
+  )
+}
+
+export default Embedded
diff --git a/ui/src/notebooks/pipes/Spotify/index.ts b/ui/src/notebooks/pipes/Spotify/index.ts
new file mode 100644
index 0000000000..b9c0c777e0
--- /dev/null
+++ b/ui/src/notebooks/pipes/Spotify/index.ts
@@ -0,0 +1,15 @@
+import {register} from 'src/notebooks'
+
+import View from './view'
+import './style.scss'
+
+register({
+  type: 'spotify',
+  priority: -1,
+  disabled: true,
+  button: 'Music',
+  component: View,
+  initial: {
+    uri: 'spotify:track:55A8N3HXzIecctUSvru3Ch',
+  },
+})
diff --git a/ui/src/notebooks/pipes/Spotify/style.scss b/ui/src/notebooks/pipes/Spotify/style.scss
new file mode 100644
index 0000000000..29e7835e06
--- /dev/null
+++ b/ui/src/notebooks/pipes/Spotify/style.scss
@@ -0,0 +1,10 @@
+.notebook-spotify {
+    text-align: center;
+}
+
+.notebook-spotify--editor {
+    width: 600px;
+    margin: 0 auto;
+
+    text-align: right;
+}
diff --git a/ui/src/notebooks/pipes/Spotify/view.tsx b/ui/src/notebooks/pipes/Spotify/view.tsx
new file mode 100644
index 0000000000..abd10efaef
--- /dev/null
+++ b/ui/src/notebooks/pipes/Spotify/view.tsx
@@ -0,0 +1,38 @@
+// Libraries
+import React, {FC, useState} from 'react'
+
+// Components
+import Embedded from './embedded'
+import Editor from './editor'
+import {SquareButton, IconFont} from '@influxdata/clockface'
+
+// Types
+import {PipeProp} from 'src/notebooks'
+
+const Spotify: FC<PipeProp> = ({Context, data, onUpdate}) => {
+  const [isEditing, setIsEditing] = useState<boolean>(false)
+  const toggleEdit = () => {
+    setIsEditing(!isEditing)
+  }
+
+  const controls = (
+    <SquareButton
+      icon={IconFont.CogThick}
+      titleText="Edit Spotify URI"
+      onClick={toggleEdit}
+    />
+  )
+
+  const showEditing = isEditing || !data.uri
+
+  return (
+    <Context controls={controls}>
+      <div className="notebook-spotify">
+        <Editor data={data} onUpdate={onUpdate} visible={showEditing} />
+        <Embedded uri={data.uri} visible={!showEditing} />
+      </div>
+    </Context>
+  )
+}
+
+export default Spotify