Reset rhh map elements to reuse allocations.

pkg/rhh/rhh.go

@@ -33,7 +33,7 @@ func NewHashMap(opt Options) *HashMap {
 func (m *HashMap) Reset() {
 	for i := int64(0); i < m.capacity; i++ {
 		m.hashes[i] = 0
-		m.elems[i] = hashElem{}
+		m.elems[i].reset()
 	}
 	m.n = 0
 }
@@ -66,15 +66,15 @@ func (m *HashMap) insert(hash int64, key []byte, val interface{}) (overwritten b
 
 	// Continue searching until we find an empty slot or lower probe distance.
 	for {
+		e := &m.elems[pos]
+
 		// Empty slot found or matching key, insert and exit.
-		if m.hashes[pos] == 0 {
+		match := bytes.Equal(m.elems[pos].key, key)
+		if m.hashes[pos] == 0 || match {
 			m.hashes[pos] = hash
-			m.elems[pos] = hashElem{hash: hash, key: key, value: val}
+			e.hash, e.value = hash, val
-			return false
+			e.setKey(key)
-		} else if bytes.Equal(m.elems[pos].key, key) {
+			return match
-			m.hashes[pos] = hash
-			m.elems[pos] = hashElem{hash: hash, key: key, value: val}
-			return true
 		}
 
 		// If the existing elem has probed less than us, then swap places with
@@ -82,11 +82,15 @@ func (m *HashMap) insert(hash int64, key []byte, val interface{}) (overwritten b
 		elemDist := Dist(m.hashes[pos], pos, m.capacity)
 		if elemDist < dist {
 			// Swap with current position.
-			e := &m.elems[pos]
 			hash, m.hashes[pos] = m.hashes[pos], hash
-			key, e.key = e.key, key
 			val, e.value = e.value, val
 
+			tmp := make([]byte, len(e.key))
+			copy(tmp, e.key)
+
+			e.setKey(key)
+			key = tmp
+
 			// Update current distance.
 			dist = elemDist
 		}
@@ -194,6 +198,26 @@ type hashElem struct {
 	hash  int64
 }
 
+// reset clears the values in the element.
+func (e *hashElem) reset() {
+	e.key = e.key[:0]
+	e.value = nil
+	e.hash = 0
+}
+
+// setKey copies v to a key on e.
+func (e *hashElem) setKey(v []byte) {
+	// Shrink or grow key to fit value.
+	if len(e.key) > len(v) {
+		e.key = e.key[:len(v)]
+	} else if len(e.key) < len(v) {
+		e.key = append(e.key, make([]byte, len(v)-len(e.key))...)
+	}
+
+	// Copy value to key.
+	copy(e.key, v)
+}
+
 // Options represents initialization options that are passed to NewHashMap().
 type Options struct {
 	Capacity   int64

tsdb/index/tsi1/series_block.go

@@ -571,7 +571,8 @@ func (enc *SeriesBlockEncoder) Encode(name []byte, tags models.Tags, deleted boo
 	}
 
 	// Save offset to generate index later.
-	enc.offsets.Put(copyBytes(buf[1:]), uint64(offset))
+	// Key is copied by the RHH map.
+	enc.offsets.Put(buf[1:], uint64(offset))
 
 	// Update sketches & trailer.
 	if deleted {