fix: Remove ng_chunk method

Connects to #4450.

compactor/src/query.rs

@@ -260,8 +260,4 @@ impl QueryChunk for QueryableParquetChunk {
         ChunkOrder::new(seq_num)
             .expect("Sequence number should have been converted to chunk order successfully")
     }
-
-    fn ng_chunk(&self) -> bool {
-        true
-    }
 }

ingester/src/query.rs

@@ -291,10 +291,6 @@ impl QueryChunk for QueryableBatch {
     fn order(&self) -> ChunkOrder {
         unimplemented!()
     }
-
-    fn ng_chunk(&self) -> bool {
-        true
-    }
 }
 
 #[cfg(test)]

querier/src/chunk/query_access.rs

@@ -160,8 +160,4 @@ impl QueryChunk for QuerierChunk {
     fn order(&self) -> ChunkOrder {
         self.meta().order()
     }
-
-    fn ng_chunk(&self) -> bool {
-        true
-    }
 }

querier/src/ingester/mod.rs

@@ -624,10 +624,6 @@ impl QueryChunk for IngesterPartition {
         // partition, put it at the end
         ChunkOrder::new(u32::MAX).unwrap()
     }
-
-    fn ng_chunk(&self) -> bool {
-        true
-    }
 }
 
 /// Ensure that the record batch has the given schema.

query/src/lib.rs

@@ -250,9 +250,6 @@ pub trait QueryChunk: QueryChunkMeta + Debug + Send + Sync + 'static {
 
     /// Order of this chunk relative to other overlapping chunks.
     fn order(&self) -> ChunkOrder;
-
-    /// TODO: remove after OG code is removed
-    fn ng_chunk(&self) -> bool;
 }
 
 /// Implement ChunkMeta for something wrapped in an Arc (like Chunks often are)

query/src/test.rs

@@ -992,12 +992,6 @@ impl QueryChunk for TestChunk {
     fn order(&self) -> ChunkOrder {
         self.order
     }
-
-    // The Test Chunk is used for both OG and NG but since OG will go away soon and
-    // this function will be removed, we apply all NG deduplication algorithms for this TestChunk
-    fn ng_chunk(&self) -> bool {
-        true
-    }
 }
 
 impl QueryChunkMeta for TestChunk {