Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
influxdb/ingester2/Cargo.toml

74 lines
2.6 KiB
TOML
Raw Normal View History

feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
[package]
name = "ingester2"
version.workspace = true
authors.workspace = true
edition.workspace = true
license.workspace = true
[dependencies]
arrow = { workspace = true, features = ["prettyprint"] }
refactor: remove iox_arrow_flight use in ingester2 (#6623) * refactor: remove iox_arrow_flight use in ingester2 * fix: Update ingester2/src/server/grpc/query.rs Co-authored-by: Dom <dom@itsallbroken.com> * chore: remove unused Error enums Co-authored-by: Dom <dom@itsallbroken.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-01-19 15:27:23 +00:00
arrow-flight = { workspace = true }
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
arrow_util = { version = "0.1.0", path = "../arrow_util" }
feat(ingester2): optimal persist parallelism This commit changes the behaviour of the persist system to enable optimal parallelism of persist operations, and improve the accuracy of the outstanding job bound / back-pressure. Previously all persist operations for a given partition were consistently hashed to a single worker task. This serialised persistence per partition, ensuring all updates to the partition sort key were serialised. However, this also unnecessarily serialises persist operations that do not need to update the sort key, reducing the potential throughput of the system; in the worst case of a single partition receiving all the writes, only one worker would be persisting, and the other N-1 workers would be idle. After this change, the sort key is inspected when enqueuing the persist operation and if it can be determined that no sort key update is necessary (the typical case), then the persist task is placed into a global work queue from which all workers consume. This allows for maximal parallelisation of these jobs, and the removes the per-worker head-of-line blocking. In the case that the sort key does need updating, these jobs continue to be consistently hashed to a single worker, ensuring serialised sort key updates only where necessary. To support these changes, the back-pressure system has been changed to account for all outstanding persist jobs in the system, regardless of type or assigned worker - a logical, bounded queue is composed together of a semaphore limiting the number of persist tasks overall, and a series of physical, unbounded queues - one to each worker & the global queue. The overall system remains bounded by the INFLUXDB_IOX_PERSIST_QUEUE_DEPTH value, and is now simpler to reason about (it is independent of the number of workers, etc).
2022-12-15 14:14:23 +00:00
async-channel = "1.8.0"
chore(deps): Bump async-trait from 0.1.61 to 0.1.63 (#6660) Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.61 to 0.1.63. - [Release notes](https://github.com/dtolnay/async-trait/releases) - [Commits](https://github.com/dtolnay/async-trait/compare/0.1.61...0.1.63) --- updated-dependencies: - dependency-name: async-trait dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-23 08:41:27 +00:00
async-trait = "0.1.63"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
backoff = { version = "0.1.0", path = "../backoff" }
feat(ingester2): gRPC methods & type-erased init This commit implements the gRPC direct-write RPC interface (largely copied from the ingester crate), and adds a much improved RPC query handler. Compared to the ingester crate, the query API is now split into two defined halves - the API handler side, and types necessary to support it (server/grpc/query.rs) and the Ingester query execution side (a stub in query/exec.rs). These two halves maintain a separation of concerns, and are interfaced by an abstract QueryExec trait (in query/trait.rs). I also added the catalog RPC interface as it is currently exposed on the ingester, though I am unsure if it is used by anything. This commit also introduces the "init" module, and the IngesterRpcInterface trait within it. This trait forms the public ingester2 crate API, defining the complete set of methods external crates can expect to utilise in a stable, unchanging and decoupled way. The IngesterRpcInterface trait also serves as a method of type-erasure on the underlying handler implementations, avoiding the need to expose/pub the types, abstractions, and internal implementation details of the ingester to external crates.
2022-11-25 10:58:32 +00:00
bytes = "1.3.0"
feat: operation timestamp sequencer Adds a TimestampOracle to provide an ingester-internal ordering to incoming DmlOperations using a logical clock.
2022-11-28 12:23:16 +00:00
crossbeam-utils = "0.8.14"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
data_types = { version = "0.1.0", path = "../data_types" }
datafusion.workspace = true
perf(ingester2): stream BufferTree partition data This commit implements the QueryExec trait for the BufferTree, allow it to be queried for the partition data it contains. With this change, the BufferTree now provides "read your writes" functionality. Notably the implementation streams the contents of individual partitions to the caller on demand (pull-based execution), deferring acquiring the partition lock until actually necessary and minimising the duration of time a strong reference to a specific RecordBatch is held in order to minimise the memory overhead. During query execution a client sees a consistent snapshot of partitions: once a client begins streaming the query response, incoming writes that create new partitions do not become visible. However incoming writes to an existing partition that forms part of the snapshot set become visible iff they are ordered before the acquisition of the partition lock when streaming that partition data to the client.
2022-11-25 14:35:39 +00:00
datafusion_util = { path = "../datafusion_util" }
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
dml = { version = "0.1.0", path = "../dml" }
feat(ingester2): gRPC methods & type-erased init This commit implements the gRPC direct-write RPC interface (largely copied from the ingester crate), and adds a much improved RPC query handler. Compared to the ingester crate, the query API is now split into two defined halves - the API handler side, and types necessary to support it (server/grpc/query.rs) and the Ingester query execution side (a stub in query/exec.rs). These two halves maintain a separation of concerns, and are interfaced by an abstract QueryExec trait (in query/trait.rs). I also added the catalog RPC interface as it is currently exposed on the ingester, though I am unsure if it is used by anything. This commit also introduces the "init" module, and the IngesterRpcInterface trait within it. This trait forms the public ingester2 crate API, defining the complete set of methods external crates can expect to utilise in a stable, unchanging and decoupled way. The IngesterRpcInterface trait also serves as a method of type-erasure on the underlying handler implementations, avoiding the need to expose/pub the types, abstractions, and internal implementation details of the ingester to external crates.
2022-11-25 10:58:32 +00:00
flatbuffers = "22"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
futures = "0.3.25"
generated_types = { version = "0.1.0", path = "../generated_types" }
hashbrown.workspace = true
iox_catalog = { version = "0.1.0", path = "../iox_catalog" }
iox_query = { version = "0.1.0", path = "../iox_query" }
iox_time = { path = "../iox_time" }
metric = { version = "0.1.0", path = "../metric" }
mutable_batch = { version = "0.1.0", path = "../mutable_batch" }
mutable_batch_pb = { version = "0.1.0", path = "../mutable_batch_pb" }
chore(deps): Bump object_store from 0.5.1 to 0.5.2 (#6339) * chore(deps): Bump object_store from 0.5.1 to 0.5.2 Bumps [object_store](https://github.com/apache/arrow-rs) from 0.5.1 to 0.5.2. - [Release notes](https://github.com/apache/arrow-rs/releases) - [Changelog](https://github.com/apache/arrow-rs/blob/master/CHANGELOG-old.md) - [Commits](https://github.com/apache/arrow-rs/compare/object_store_0.5.1...object_store_0.5.2) --- updated-dependencies: - dependency-name: object_store dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore: Run cargo hakari tasks Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: CircleCI[bot] <circleci@influxdata.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-12-06 07:53:54 +00:00
object_store = "0.5.2"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
observability_deps = { version = "0.1.0", path = "../observability_deps" }
chore(deps): Bump once_cell from 1.16.0 to 1.17.0 (#6473) * chore(deps): Bump once_cell from 1.16.0 to 1.17.0 Bumps [once_cell](https://github.com/matklad/once_cell) from 1.16.0 to 1.17.0. - [Release notes](https://github.com/matklad/once_cell/releases) - [Changelog](https://github.com/matklad/once_cell/blob/master/CHANGELOG.md) - [Commits](https://github.com/matklad/once_cell/compare/v1.16.0...v1.17.0) --- updated-dependencies: - dependency-name: once_cell dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore: Change once_cell version specifier to major.minor for less churn Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carol (Nichols || Goulding) <carol.nichols@gmail.com>
2023-01-02 17:07:15 +00:00
once_cell = "1.17"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
parking_lot = "0.12.1"
feat(ingester2): parallel partition persistence Implements actor-based, parallel persistence in ingester2 with controllable fan-out parallelism and queue depths. This implementation encapsulates the complexity of persistence, queuing and parallelism - the caller simply uses the handle to persist a partition, while the actor handles fan-out to a set of persistence workers, compaction in a separate thread-pool, and optional completion notifications. By consistently hashing persist jobs onto workers, parallelism is achieved across partitions, but serialisation of partition persists is enforced so that the sort key update is correctly serialised.
2022-12-01 09:37:25 +00:00
parquet_file = { version = "0.1.0", path = "../parquet_file" }
feat(ingester2): gRPC methods & type-erased init This commit implements the gRPC direct-write RPC interface (largely copied from the ingester crate), and adds a much improved RPC query handler. Compared to the ingester crate, the query API is now split into two defined halves - the API handler side, and types necessary to support it (server/grpc/query.rs) and the Ingester query execution side (a stub in query/exec.rs). These two halves maintain a separation of concerns, and are interfaced by an abstract QueryExec trait (in query/trait.rs). I also added the catalog RPC interface as it is currently exposed on the ingester, though I am unsure if it is used by anything. This commit also introduces the "init" module, and the IngesterRpcInterface trait within it. This trait forms the public ingester2 crate API, defining the complete set of methods external crates can expect to utilise in a stable, unchanging and decoupled way. The IngesterRpcInterface trait also serves as a method of type-erasure on the underlying handler implementations, avoiding the need to expose/pub the types, abstractions, and internal implementation details of the ingester to external crates.
2022-11-25 10:58:32 +00:00
pin-project = "1.0.12"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
predicate = { version = "0.1.0", path = "../predicate" }
chore(deps): Bump prost from 0.11.5 to 0.11.6 Bumps [prost](https://github.com/tokio-rs/prost) from 0.11.5 to 0.11.6. - [Release notes](https://github.com/tokio-rs/prost/releases) - [Commits](https://github.com/tokio-rs/prost/compare/v0.11.5...v0.11.6) --- updated-dependencies: - dependency-name: prost dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
2023-01-11 02:53:33 +00:00
prost = { version = "0.11.6", default-features = false, features = ["std"] }
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
rand = "0.8.5"
schema = { version = "0.1.0", path = "../schema" }
service_grpc_catalog = { version = "0.1.0", path = "../service_grpc_catalog" }
feat(ingester2): parallel partition persistence Implements actor-based, parallel persistence in ingester2 with controllable fan-out parallelism and queue depths. This implementation encapsulates the complexity of persistence, queuing and parallelism - the caller simply uses the handle to persist a partition, while the actor handles fan-out to a set of persistence workers, compaction in a separate thread-pool, and optional completion notifications. By consistently hashing persist jobs onto workers, parallelism is achieved across partitions, but serialisation of partition persists is enforced so that the sort key update is correctly serialised.
2022-12-01 09:37:25 +00:00
sharder = { version = "0.1.0", path = "../sharder" }
chore(deps): Bump thiserror from 1.0.37 to 1.0.38 Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.37 to 1.0.38. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](https://github.com/dtolnay/thiserror/compare/1.0.37...1.0.38) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
2022-12-19 10:33:32 +00:00
thiserror = "1.0.38"
fix: drop WAL segments after replay Changes the WAL replay logic to: * Replay a segment file * Persist all replayed data * Drop segment file * ...repeat... This ensures old WAL segments are removed once their contents have been made durable, fixing #6461.
2022-12-22 15:53:48 +00:00
test_helpers = { path = "../test_helpers", features = ["future_timeout"], optional = true }
chore(deps): Bump tokio from 1.24.0 to 1.24.1 (#6545) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.24.0 to 1.24.1. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](https://github.com/tokio-rs/tokio/compare/tokio-1.24.0...tokio-1.24.1) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-01-10 09:48:44 +00:00
tokio = { version = "1.24", features = ["macros", "parking_lot", "rt-multi-thread", "sync", "time"] }
chore(deps): Bump tonic from 0.8.2 to 0.8.3 (#6249) Bumps [tonic](https://github.com/hyperium/tonic) from 0.8.2 to 0.8.3. - [Release notes](https://github.com/hyperium/tonic/releases) - [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md) - [Commits](https://github.com/hyperium/tonic/compare/v0.8.2...v0.8.3) --- updated-dependencies: - dependency-name: tonic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-11-29 09:53:30 +00:00
tonic = "0.8.3"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
trace = { version = "0.1.0", path = "../trace" }
uuid = "1.2.2"
feat(ingester2): commit writes to write-ahead log Adds WalSink, an implementation of the DmlSink trait that commits DML operations to the write-ahead log before passing the DML op into the decorated inner DmlSink chain. By structuring the WAL logic as a decorator, the chain of inner DmlSink handlers within it are only ever invoked after the WAL commit has successfully completed, which keeps all the WAL commit code in a singly-responsible component. This also lets us layer on the WAL commit logic to the DML sink chain after replaying any existing WAL files, avoiding a circular WAL mess. The application-logic level WAL code abstracts over the underlying WAL implementation & codec through the WalAppender trait. This decouples the business logic from the WAL implementation both for testing purposes, and for trying different WAL implementations in the future.
2022-11-28 22:09:03 +00:00
wal = { version = "0.1.0", path = "../wal" }
chore: Run cargo hakari tasks
2022-11-24 14:51:21 +00:00
workspace-hack = { path = "../workspace-hack"}
refactor: delegate frontend shutdown to backend Prior to this commit, the (happy path) shutdown sequence of an IOx process was hard coded to: 1. Stop gRPC & HTTP servers 2. Stop backend server (i.e. ingester2) After this commit, the execution of step 1 is delegated to the handler for step 2; the server implementation (router / ingester / querier / etc) now chooses when to shut down the RPC & HTTP servers. This allows the server shutdown delegate to correctly sequence the shutdown of all components of the IOx server. This allows ingester2 to correctly sequence the shutdown of the query RPC server w.r.t the graceful stop & persist, ensuring queries continue to be serviced.
2023-01-12 13:59:50 +00:00
tokio-util = "0.7.4"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
[dev-dependencies]
assert_matches = "1.5.0"
test(ingester2): WAL replay benchmark This adds a simple WAL replay benchmark to ingester2 that executes a replay of a single line of LP. Unfortunately each file in the benches directory is compiled as it's own binary/crate, and as such is restricted to importing only "pub" types. This sucks, as it requires you to either benchmark at a high level (macro, not microbenchmarks - i.e. benchmarking the ingester startup, not just the WAL replay) or you are forced to mark the reliant types & functions as "pub", as well as all the other types/traits they reference in their signatures. Because the performance sensitive code is usually towards the lower end of the call stack, this can quickly lead to an explosion of "pub" types causing a large amount of internal code to be exported. Instead this commit uses a middle-ground; benchmarked types & fns are conditionally marked as "pub" iff the "benches" feature is enabled. This prevents them from being visible by default, but allows the benchmark function to call them. The benchmark itself is also restricted to only run when this feature is enabled.
2022-12-12 13:24:11 +00:00
criterion = { version = "0.4", default-features = false, features = ["async_tokio"]}
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
datafusion_util = { path = "../datafusion_util" }
lazy_static = "1.4.0"
mutable_batch_lp = { path = "../mutable_batch_lp" }
chore(deps): Bump paste from 1.0.10 to 1.0.11 (#6430) Bumps [paste](https://github.com/dtolnay/paste) from 1.0.10 to 1.0.11. - [Release notes](https://github.com/dtolnay/paste/releases) - [Commits](https://github.com/dtolnay/paste/compare/1.0.10...1.0.11) --- updated-dependencies: - dependency-name: paste dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2022-12-19 10:31:05 +00:00
paste = "1.0.11"
feat(ingester2): commit writes to write-ahead log Adds WalSink, an implementation of the DmlSink trait that commits DML operations to the write-ahead log before passing the DML op into the decorated inner DmlSink chain. By structuring the WAL logic as a decorator, the chain of inner DmlSink handlers within it are only ever invoked after the WAL commit has successfully completed, which keeps all the WAL commit code in a singly-responsible component. This also lets us layer on the WAL commit logic to the DML sink chain after replaying any existing WAL files, avoiding a circular WAL mess. The application-logic level WAL code abstracts over the underlying WAL implementation & codec through the WalAppender trait. This decouples the business logic from the WAL implementation both for testing purposes, and for trying different WAL implementations in the future.
2022-11-28 22:09:03 +00:00
tempfile = "3.3.0"
feat(ingester): ingester2 init Adds an ingester2 crate to hold the MVP of the Kafkaless project. This was necessary due to the tight coupling of the ingester internals with tests in external crates, and eases the parallel development of two version of the ingester. This commit contains various changes from the "ingester" crate, mostly removing the concept/references to a "shard" or "ShardId" where possible. This commit does not copy over all of the "ingester" crate - only those components that are definitely needed. I will drag across more as functionality is implemented.
2022-11-24 14:26:34 +00:00
test_helpers = { path = "../test_helpers", features = ["future_timeout"] }
test(ingester2): WAL replay benchmark This adds a simple WAL replay benchmark to ingester2 that executes a replay of a single line of LP. Unfortunately each file in the benches directory is compiled as it's own binary/crate, and as such is restricted to importing only "pub" types. This sucks, as it requires you to either benchmark at a high level (macro, not microbenchmarks - i.e. benchmarking the ingester startup, not just the WAL replay) or you are forced to mark the reliant types & functions as "pub", as well as all the other types/traits they reference in their signatures. Because the performance sensitive code is usually towards the lower end of the call stack, this can quickly lead to an explosion of "pub" types causing a large amount of internal code to be exported. Instead this commit uses a middle-ground; benchmarked types & fns are conditionally marked as "pub" iff the "benches" feature is enabled. This prevents them from being visible by default, but allows the benchmark function to call them. The benchmark itself is also restricted to only run when this feature is enabled.
2022-12-12 13:24:11 +00:00
[features]
fix: drop WAL segments after replay Changes the WAL replay logic to: * Replay a segment file * Persist all replayed data * Drop segment file * ...repeat... This ensures old WAL segments are removed once their contents have been made durable, fixing #6461.
2022-12-22 15:53:48 +00:00
benches = ["test_helpers"] # Export some internal types for benchmark purposes only.
test(ingester2): WAL replay benchmark This adds a simple WAL replay benchmark to ingester2 that executes a replay of a single line of LP. Unfortunately each file in the benches directory is compiled as it's own binary/crate, and as such is restricted to importing only "pub" types. This sucks, as it requires you to either benchmark at a high level (macro, not microbenchmarks - i.e. benchmarking the ingester startup, not just the WAL replay) or you are forced to mark the reliant types & functions as "pub", as well as all the other types/traits they reference in their signatures. Because the performance sensitive code is usually towards the lower end of the call stack, this can quickly lead to an explosion of "pub" types causing a large amount of internal code to be exported. Instead this commit uses a middle-ground; benchmarked types & fns are conditionally marked as "pub" iff the "benches" feature is enabled. This prevents them from being visible by default, but allows the benchmark function to call them. The benchmark itself is also restricted to only run when this feature is enabled.
2022-12-12 13:24:11 +00:00
[lib]
bench = false
[[bench]]
name = "wal"
harness = false
# Require some internal types be made visible for benchmark code.
required-features = ["benches"]