Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
influxdb/storage/readservice/service.go

15 lines
434 B
Go
Raw Normal View History

chore: refactor reads service and make it consumable externally This pulls in the code that allows doing reads with flux into the platform repo, and removes extra.go. The reusable portion is under storage/reads, where the concrete implementation for one of the platform's engines is in storage/readservice. In order to make this more reusable, the cursors had to move into their own package, decoupling it from all of the other code in the tsdb package. tsdb/cursors is this new package, and type/function aliases have been added to the tsdb package to point at it. The models package already is very light on transitive dependencies and so it was allowed to be depended on in a concrete way in the cursors package. Finally, the protobuf definitions for issuing GRPC reads has been moved into its own package for two reasons: 1. It's a clean separation, and helps keep it that way. 2. Many/most consumers will not be using GRPC. We just use the datatypes to express the API which helps making a GRPC server easier. It is left up to future refactorings (specifically ones that involve GPRC) to determine if these types should remain, or if there is a cleaner way. There's still some dependencies on both github.com/influxdata/influxql and github.com/influxdata/influxdb/logger that we can hopefully remove in future refactorings.
2018-10-05 22:02:31 +00:00
package readservice
import (
refactor: rewrite imports to include the /v2 suffix for version 2
2020-04-03 17:39:20 +00:00
"github.com/influxdata/influxdb/v2/query"
"github.com/influxdata/influxdb/v2/query/control"
chore: refactor reads service and make it consumable externally This pulls in the code that allows doing reads with flux into the platform repo, and removes extra.go. The reusable portion is under storage/reads, where the concrete implementation for one of the platform's engines is in storage/readservice. In order to make this more reusable, the cursors had to move into their own package, decoupling it from all of the other code in the tsdb package. tsdb/cursors is this new package, and type/function aliases have been added to the tsdb package to point at it. The models package already is very light on transitive dependencies and so it was allowed to be depended on in a concrete way in the cursors package. Finally, the protobuf definitions for issuing GRPC reads has been moved into its own package for two reasons: 1. It's a clean separation, and helps keep it that way. 2. Many/most consumers will not be using GRPC. We just use the datatypes to express the API which helps making a GRPC server easier. It is left up to future refactorings (specifically ones that involve GPRC) to determine if these types should remain, or if there is a cleaner way. There's still some dependencies on both github.com/influxdata/influxql and github.com/influxdata/influxdb/logger that we can hopefully remove in future refactorings.
2018-10-05 22:02:31 +00:00
)
refactor(query): explicitly shut down query controller The flux query controller was updated to include a Shutdown method a while ago. Explicitly handle query controller creation and shutdown where applicable. In influxd, this ensures that outstanding queries are handled before the process dies. In tests, this ensures that query controller goroutines aren't leaked, which drastically simplifies reading full stack traces. This change also registers query controller metrics with the prometheus registry in influxd.
2018-11-26 17:43:09 +00:00
// NewProxyQueryService returns a proxy query service based on the given queryController
// suitable for the storage read service.
refactor(query/control): move the controller from flux to influxdb (#13991) The controller implementation is primarily used by influxdb so it shouldn't be part of the flux repository. This copies the code from flux to influxdb so it can be removed from the next flux release.
2019-05-29 14:04:34 +00:00
func NewProxyQueryService(queryController *control.Controller) query.ProxyQueryService {
refactor(query): make queryd present ProxyQueryService (#12360) Fixes influxdata/idpe#2014.
2019-03-07 15:32:13 +00:00
return query.ProxyQueryServiceAsyncBridge{
AsyncQueryService: queryController,
chore: refactor reads service and make it consumable externally This pulls in the code that allows doing reads with flux into the platform repo, and removes extra.go. The reusable portion is under storage/reads, where the concrete implementation for one of the platform's engines is in storage/readservice. In order to make this more reusable, the cursors had to move into their own package, decoupling it from all of the other code in the tsdb package. tsdb/cursors is this new package, and type/function aliases have been added to the tsdb package to point at it. The models package already is very light on transitive dependencies and so it was allowed to be depended on in a concrete way in the cursors package. Finally, the protobuf definitions for issuing GRPC reads has been moved into its own package for two reasons: 1. It's a clean separation, and helps keep it that way. 2. Many/most consumers will not be using GRPC. We just use the datatypes to express the API which helps making a GRPC server easier. It is left up to future refactorings (specifically ones that involve GPRC) to determine if these types should remain, or if there is a cleaner way. There's still some dependencies on both github.com/influxdata/influxql and github.com/influxdata/influxdb/logger that we can hopefully remove in future refactorings.
2018-10-05 22:02:31 +00:00
}
refactor(query): explicitly shut down query controller The flux query controller was updated to include a Shutdown method a while ago. Explicitly handle query controller creation and shutdown where applicable. In influxd, this ensures that outstanding queries are handled before the process dies. In tests, this ensures that query controller goroutines aren't leaked, which drastically simplifies reading full stack traces. This change also registers query controller metrics with the prometheus registry in influxd.
2018-11-26 17:43:09 +00:00
}