influxdb/docs/contributing.md

79 lines
2.6 KiB
Markdown
Raw Normal View History

2014-07-15 16:52:17 +00:00
Contributing to InfluxDB
========================
2014-07-15 20:01:33 +00:00
InfluxDB follows standard Go project structure. This means that all
2014-07-15 16:52:17 +00:00
your go development are done in $GOPATH/src. GOPATH can be any
directory under which InfluxDB and all it's dependencies will be
cloned. For more details on recommended go project's structure, see
2014-09-28 18:06:45 +00:00
[How to Write Go Code](http://golang.org/doc/code.html]) and
[Go: Best Practices for Production Environments](http://peter.bourgon.org/go-in-production/), or you can just follow
2014-07-15 16:52:17 +00:00
the steps below.
Signing the CLA
---------------
If you are going to be contributing back to InfluxDB please take a
second to sign our CLA, which can be found
[on our website](http://influxdb.com/community/cla.html)
2014-11-03 02:14:31 +00:00
Installing go
-------------
2014-07-15 16:52:17 +00:00
I recommend using gvm which is a go version manager. For instructions
on how to install see
[gvm page on github](https://github.com/moovweb/gvm). InfluxDB
currently works with go 1.3 and newer version only.
2014-07-15 16:52:17 +00:00
After installing gvm you can install and set the default go version by
running the following:
gvm install go1.3
gvm use go1.3 --default
2014-07-15 16:52:17 +00:00
Project structure
-----------------
First you need to setup the project structure
export GOPATH=$HOME/gocodez
mkdir -p $GOPATH/src/github.com/influxdb
cd $GOPATH/src/github.com/influxdb
git clone git@github.com:influxdb/influxdb
2014-07-17 16:49:45 +00:00
You can add the line `export GOPATH=$HOME/gocodez` to your bash/zsh
file to be set for every shell instead of having to manually run it
everytime.
2014-07-15 16:52:17 +00:00
We have a pre commit hook to make sure code is formatted properly
before you commit any changes. We strongly recommend using the pre
commit hook to guard against accidentally committing unformatted
code. To use the pre-commit hook, run the following:
cd $GOPATH/src/github.com/influxdb/influxdb
2014-07-15 17:00:21 +00:00
cp .hooks/pre-commit .git/hooks/
2014-07-15 16:52:17 +00:00
2014-07-15 16:55:38 +00:00
In case the commit is rejected because it's not formatted you can run
the following to format the code:
2014-11-18 21:58:11 +00:00
Build
-----
2014-07-15 16:55:38 +00:00
2014-11-18 21:58:11 +00:00
Make sure you have Go installed. Here are some common things you'd want to run:
2014-07-17 16:49:45 +00:00
2014-11-18 21:58:11 +00:00
```bash
go test -v
2014-07-15 16:52:17 +00:00
2014-11-18 21:58:11 +00:00
# run tests that match some pattern
go test -run=TestDatabase . -v
2014-07-15 16:52:17 +00:00
2014-11-18 21:58:11 +00:00
# run tests and show coverage
go test -coverprofile /tmp/cover . && go tool cover -html /tmp/cover
```
2014-07-17 16:36:01 +00:00
Useful links
------------
- [Useful techniques in Go](http://arslan.io/ten-useful-techniques-in-go)
- [Go in production](http://peter.bourgon.org/go-in-production/)
- [Principles of designing Go APIs with channels](https://inconshreveable.com/07-08-2014/principles-of-designing-go-apis-with-channels/)
- [Common mistakes in Golang](http://soryy.com/blog/2014/common-mistakes-with-go-lang/). Especially this section `Loops, Closures, and Local Variables`