Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
influxdb/storage/reads/gen.go

10 lines
798 B
Go
Raw Normal View History

chore: refactor reads service and make it consumable externally This pulls in the code that allows doing reads with flux into the platform repo, and removes extra.go. The reusable portion is under storage/reads, where the concrete implementation for one of the platform's engines is in storage/readservice. In order to make this more reusable, the cursors had to move into their own package, decoupling it from all of the other code in the tsdb package. tsdb/cursors is this new package, and type/function aliases have been added to the tsdb package to point at it. The models package already is very light on transitive dependencies and so it was allowed to be depended on in a concrete way in the cursors package. Finally, the protobuf definitions for issuing GRPC reads has been moved into its own package for two reasons: 1. It's a clean separation, and helps keep it that way. 2. Many/most consumers will not be using GRPC. We just use the datatypes to express the API which helps making a GRPC server easier. It is left up to future refactorings (specifically ones that involve GPRC) to determine if these types should remain, or if there is a cleaner way. There's still some dependencies on both github.com/influxdata/influxql and github.com/influxdata/influxdb/logger that we can hopefully remove in future refactorings.
2018-10-05 22:02:31 +00:00
package reads
refactor: modify tooling to take advantage of go run The generate commands have been modified to take advantage of the new functionality in Go 1.11 that allows `go run` to execute a package instead of individual files. This functionality combined with Go modules allows us to execute a package directly out of our pinned dependencies rather than accidentally picking up another binary outside of the build environment. This also simplifies the Makefile because they no longer have to be responsible for installing the correct tooling since the Go command takes care of that logic. It also makes it so that the Makefiles with file generation can now be invoked from their appropriate subdirectories so they are contained within the directory itself rather than relying on values in the top level Makefile. It is now possible to generate all files within this project by using: go generate ./... Or the Makefile can continue to be used. This commit also copies over the special copy of `tmpl` that the storage engine uses within the influxdb repository. It was never copied over so using `go generate` on these packages did not work.
2018-10-15 14:39:01 +00:00
//go:generate env GO111MODULE=on go run github.com/benbjohnson/tmpl -data=@array_cursor.gen.go.tmpldata array_cursor.gen.go.tmpl
//go:generate env GO111MODULE=on go run github.com/benbjohnson/tmpl -data=@array_cursor.gen.go.tmpldata response_writer.gen.go.tmpl
feat(reads): Implement ResultSet and GroupResultSet for protobuf streams
2018-11-20 18:37:30 +00:00
//go:generate env GO111MODULE=on go run github.com/benbjohnson/tmpl -data=@array_cursor.gen.go.tmpldata stream_reader.gen.go.tmpl
//go:generate env GO111MODULE=on go run github.com/benbjohnson/tmpl -data=@array_cursor.gen.go.tmpldata stream_reader_gen_test.go.tmpl
build(Makefile): fix various bug with makefiles Fixes subdir ordering. Works around issue with stringer not working with Go modules. Fixes issues with generated code being ignored. Fixes #2044
2018-12-19 23:43:45 +00:00
// Stringer is not compatible with Go modules, see https://github.com/influxdata/platform/issues/2017
// For now we are disabling the command. If it needs to be regenerated you must do so manually.
////go:generate stringer -type=readState -trimprefix=state