From 30f7495a72db19c0e8d56e66436139e1a966e803 Mon Sep 17 00:00:00 2001 From: Jason Stirnaman Date: Tue, 13 May 2025 16:05:42 -0500 Subject: [PATCH 1/4] chore(hugo): Update shortcodes and templates to avoid calling isset on --- layouts/_default/page-list.json | 16 ++++++------ layouts/partials/article/flux-contrib.html | 2 +- .../partials/article/flux-experimental.html | 2 +- layouts/partials/article/tags.html | 4 +-- layouts/partials/header/title.html | 6 ++--- layouts/partials/sidebar/nested-menu.html | 14 +++++----- layouts/shortcodes/children.html | 26 +++++++++---------- layouts/shortcodes/icon.html | 6 ++++- layouts/shortcodes/nav-icon.html | 5 +++- 9 files changed, 44 insertions(+), 37 deletions(-) diff --git a/layouts/_default/page-list.json b/layouts/_default/page-list.json index 507009897..e40823ffa 100644 --- a/layouts/_default/page-list.json +++ b/layouts/_default/page-list.json @@ -8,49 +8,49 @@ {{- if $index -}},{{- end }} { "name": {{ .Name | jsonify }}, - "url": {{ absURL (cond (isset .Params "url") .Params.url .URL) | jsonify }}, + "url": {{ absURL (default .URL .Params.url) | jsonify }}, "children": [ {{- range $index, $entry := .Children -}} {{- if $index -}},{{- end }} { "name": {{ .Name | jsonify }}, - "url": {{ absURL (cond (isset .Params "url") .Params.url .URL) | jsonify }}, + "url": {{ absURL (default .URL .Params.url) | jsonify }}, "children": [ {{- range $index, $entry := .Children -}} {{- if $index -}},{{- end }} { "name": {{ .Name | jsonify }}, - "url": {{ absURL (cond (isset .Params "url") .Params.url .URL) | jsonify }}, + "url": {{ absURL (default .URL .Params.url) | jsonify }}, "children": [ {{- range $index, $entry := .Children -}} {{- if $index -}},{{- end }} { "name": {{ .Name | jsonify }}, - "url": {{ absURL (cond (isset .Params "url") .Params.url .URL) | jsonify }}, + "url": {{ absURL (default .URL .Params.url) | jsonify }}, "children": [ {{- range $index, $entry := .Children -}} {{- if $index -}},{{- end }} { "name": {{ .Name | jsonify }}, - "url": {{ absURL (cond (isset .Params "url") .Params.url .URL) | jsonify }}, + "url": {{ absURL (default .URL .Params.url) | jsonify }}, "children": [ {{- range $index, $entry := .Children -}} {{- if $index -}},{{- end }} { "name": {{ .Name | jsonify }}, - "url": {{ absURL (cond (isset .Params "url") .Params.url .URL) | jsonify }}, + "url": {{ absURL (default .URL .Params.url) | jsonify }}, "children": [ {{- range $index, $entry := .Children -}} {{- if $index -}},{{- end }} { "name": {{ .Name | jsonify }}, - "url": {{ absURL (cond (isset .Params "url") .Params.url .URL) | jsonify }}, + "url": {{ absURL (default .URL .Params.url) | jsonify }}, "children": [ {{- range $index, $entry := .Children -}} {{- if $index -}},{{- end }} { "name": {{ .Name | jsonify }}, - "url": {{ absURL (cond (isset .Params "url") .Params.url .URL) | jsonify }}, + "url": {{ absURL (default .URL .Params.url) | jsonify }}, "children": [ {{ range .Children }} {{ end }} diff --git a/layouts/partials/article/flux-contrib.html b/layouts/partials/article/flux-contrib.html index dbd317e1d..6a0d1c749 100644 --- a/layouts/partials/article/flux-contrib.html +++ b/layouts/partials/article/flux-contrib.html @@ -13,7 +13,7 @@ {{ else if eq .Kind "section" }}
- {{ $packageTitle := cond (isset .Params "list_title") $.Params.list_title .Title }} + {{ $packageTitle := default .Title .Params.list_title }} {{ $packageName := replaceRE `^(.*)( package)` "$1$2" $packageTitle }}

The {{ $packageName | safeHTML }} is a user-contributed package diff --git a/layouts/partials/article/flux-experimental.html b/layouts/partials/article/flux-experimental.html index 3f951abff..9c3b75c50 100644 --- a/layouts/partials/article/flux-experimental.html +++ b/layouts/partials/article/flux-experimental.html @@ -13,7 +13,7 @@

{{ else if eq .Kind "section" }}
- {{ $packageTitle := cond (isset .Params "list_title") $.Params.list_title .Title }} + {{ $packageTitle := default .Title .Params.list_title }} {{ $packageName := replaceRE `^(.*)( package)` "$1$2" $packageTitle }}

The {{ $packageName | safeHTML }} is experimental and subject to change at any time. diff --git a/layouts/partials/article/tags.html b/layouts/partials/article/tags.html index 60b2f48ca..4c297c861 100644 --- a/layouts/partials/article/tags.html +++ b/layouts/partials/article/tags.html @@ -2,9 +2,9 @@ {{ $product := index $productPathData 0 }} {{ $version := index $productPathData 1 }} {{ $tagSet := print $product "/" $version "/tags" }} -{{ if isset .Params $tagSet }} +{{ with .Param $tagSet }}

- {{ range .Param $tagSet }} + {{ range . }} {{ $name := . }} {{ with $.Site.GetPage (printf "/%s/%s" $tagSet ($name | urlize)) }} {{ $name }} diff --git a/layouts/partials/header/title.html b/layouts/partials/header/title.html index e6b1c8910..0ef890d79 100644 --- a/layouts/partials/header/title.html +++ b/layouts/partials/header/title.html @@ -35,10 +35,10 @@ {{ else if eq $currentVersion nil}} {{ $scratch.Set "siteTitle" (print (index .Site.Data.products $product).name " Documentation") }} {{ else }} - {{ if (isset (index .Site.Data.products $product) "altname" ) }} - {{ $scratch.Set "siteTitle" (print (index .Site.Data.products $product).altname " Documentation") }} + {{ with (index .Site.Data.products $product).altname }} + {{ $scratch.Set "siteTitle" (print . " Documentation") }} {{ else }} - {{ $scratch.Set "siteTitle" (print (index .Site.Data.products $product).name " Documentation") }} + {{ $scratch.Set "siteTitle" (print (index $.Site.Data.products $product).name " Documentation") }} {{ end }} {{ end }} diff --git a/layouts/partials/sidebar/nested-menu.html b/layouts/partials/sidebar/nested-menu.html index feceb9ea8..0083b2a3e 100644 --- a/layouts/partials/sidebar/nested-menu.html +++ b/layouts/partials/sidebar/nested-menu.html @@ -4,37 +4,37 @@ {{ range $menu }}