Chronograf includes a number of canned dashboards, whose cells are predefined
and immutable. A cell in a canned dashboard is called a layout cell, and it has
a slightly different schema than a cell in a user-defined dashboard (called
a dashboard cell).
For legacy reasons, Chronograf is able to render a layout cell or dashboard
cell using the same components via a mix of duck-typing and defensive
programming. [#4488][0] attempted to unify the differences between the two
possible cell schemas by converting a layout cell to a dashboard cell upon
read. This schema conversion was error prone and incomplete.
One difference between a layout cell and dashboard cell that was not handled by
the schema conversion involved the `groupbys` and `wheres` fields in a layout
cell. In a dashboard cell, these data are stored in the `queryConfig` object
instead. The schema conversion omitted these data altogether in the converted
cell, which caused the behavior described in [#4789][1]
This commit changes to schema conversion to include all data from the original
layout cell in the converted cell, so that the `groupbys` and `wheres` fields
are present. Downstream, the `Layout` component will check for these fields
when determining how to build a query for a cell.
This is a messy solution that builds upon previous messy solutions. [#4488][0]
discusses some alternatives, which were deemed not worth the effort to
implement.
[0]: https://github.com/influxdata/chronograf/pull/4488
[1]: https://github.com/influxdata/chronograf/issues/4789
Chronograf includes a number of canned dashboards, whose cells are predefined
and immutable. A cell in a canned dashboard is called a layout cell, and it has
a slightly different schema than a cell in a user-defined dashboard (called
a dashboard cell).
For legacy reasons, Chronograf is able to render a layout cell or dashboard
cell using the same components via a mix of duck-typing and defensive
programming. [#4488][0] attempted to unify the differences between the two
possible cell schemas by converting a layout cell to a dashboard cell upon
read. This schema conversion was error prone and incomplete.
One difference between a layout cell and dashboard cell that was not handled by
the schema conversion involved the `groupbys` and `wheres` fields in a layout
cell. In a dashboard cell, these data are stored in the `queryConfig` object
instead. The schema conversion omitted these data altogether in the converted
cell, which caused the behavior described in [#4789][1]
This commit changes to schema conversion to include all data from the original
layout cell in the converted cell, so that the `groupbys` and `wheres` fields
are present. Downstream, the `Layout` component will check for these fields
when determining how to build a query for a cell.
This is a messy solution that builds upon previous messy solutions. [#4488][0]
discusses some alternatives, which were deemed not worth the effort to
implement.
[0]: https://github.com/influxdata/chronograf/pull/4488
[1]: https://github.com/influxdata/chronograf/issues/4789
* Use category tree to build schema explorer
* Remove expander from tag value list item
* Prevent clicking tag value item from closing tag values
* Remove input from under TAGS item in schema explorer
* Search for fields in measurements
* Add loading state and use search term in fetching tag values
* Add load more tag values button and debounce tag values search
* Add error handling to flux schema explorer
fix(logs/table): add hostname column
* Guarantee hostname column exists on logviewer config
* Add hostname field to ui utils
* Update integrations server test
* Update changelog 1.7.0
Co-authored-by: Michael Desa <mjdesa@gmail.com>
fix(logs/scroll): fix the horizontal scroll bar
* Update grid to have minWidth
* Fix logs scrollbar position
* Clean up unnecessary handlers
* Update 1.7.0 changelog
Co-authored-by: Alex P <thealexpaxton@gmail.com>
Having the button in the lower right created a frustrating UX when the
message was expanded and the user was attempting to copy.
Co-authored-by: Alex Paxton <thealexpaxton@gmail.com>
* Update logs table loading time and timestamp
* Make time bounds in searching state have gradient text
* Add loading animation
* Add graphic for logs No Results state
* Update CHANGELOG 1.7 UI IMPROVEMENTS
* Update default logs message
Co-authored-by: Alex Paxton <thealexpaxton@gmail.com>
This commit improves the loading performance of static assets on devices
with low CPU, such as Pies or other embedded devices.
One characteristic of these devices is that they don't often have the
intrinsics available used in gzip compression.
This commit does two things:
(1) Adds an option to explicitly disable gzip compression of requested
assets.
(2) Avoids the very expensive URL prefix Handler wrapper if no base
path has been set.
* fix: add back meta queries dropdown to DECEO via ActionDropdown
* feat: add ActionDropdown to reusable_ui
* refactor: clean up metaqueries template options
* change button text to 'Metaquery Template'
* update changelog
* Polish
* Extend Dropdown to allow for 2 different modes
* Guard against undefined selectedChild in dropdown
* Make id strings more unique
* WIP Replace ActionDropdown with Regular Dropdown in "ActionList" mode
* remove ActionDropdown since obsolete basedon 5902026
* Create workers for flux fetch and response decoding
Co-authored-by: Brandon Farmer <bthesorceror@gmail.com>
* Add flux data to linegraph
* Fix error when queryConfigs are undefined
* Add service as prop instead of treating source as either service or source
* Fix raw data view after changing components
* Remove commented code
* Update Changelog
* Fix tests
* Remove unnecessary comment
* Rename timeSeries and data for clarity
* Add try catch around worker jobs
* Add type annotations
* Remove unncessary check
* Update to use descriptive variables
* fix: render invalid Alerts Table row data as mdash
create new AlertsTableRow component
refactor Alerts Table rows to use new AlertsTableRow component
* test AlertsTableRow for valid data
render spans for all alerts table row cell values
* update changelog
Convert HostsPage and HostsTable to typescript
Display page-spinner if hostpage in loading state
Add error state to HostsPage
Fix tests for HostsPage
Update Changelog
Add missing type definitions to HostsTable
* WIP
* Use divs instead of background image URI
* Make cell resizer prettier
* Only show cell resizer on cell hover
* Make linter happy
* Redesign layout cell to adapt to single stat coloration and have spicy new aesthetic
* Guard against cellBackgroundColor getting set to null
* Add error boundary to cell header
* Polish
* Make custom time indicator more legible
* Update changelog
* Cleanup the code!
feat: refactor log viewer to progressively load and render logs
Logs are progressively tailed to a buffer every 5000ms
while live updating. This is easily customizable. After
30000ms, this tail buffer is flushed to the "backward"
logs. This buffer was introduced to avoid losing logs
newly written to the database. This could easily be
extended to be a rolling buffer to be even more robust.
Also adds an Upper and Lower timestamp in the UI to
indicate to the user what the current search space time
bounds are.
Also removes logs from local storage.
Also fixers awaiting retrieving namespaces in order to
perform subsequent ajax requests & dispatches.
Also renames various functions & vars for clarity,
corrects typos, and corrects capitalization according
to convention.
Also removes LIMIT on fetch older and newer.
Also replaces bounds stored in Redux with UTC time.
Additionally, all the following:
* Fix LogsTable scroll loading indicator
* Move constants out of logs page
* Update newer chunk to be 100
* Fix tailing when custom/relative set
* Update chunk sizes to 30sec
* Update to use shouldLiveUpdate getter
* Fix scrollToRow after fetchNewer
* Update to use clearTailInterval
* Update scrollTo middle of backward if no forward data
* Remove last/first query time logic from logsTable
* Removing the last/first query time logic fixed scrolling
not working after performing a search and then deleting
the filter.
* Replace undefined currentNewer w/ nextNewerLower
* Add missing source redirection
* Remove comment deleted Paused status
* Add await to notify when no results are found
* Update fetchNewer to avoid chunking far into the future
* Update nextNewerLowerBound onChooseRelative
* Update lower bound on custom selection
* Update no results loading status
* Add comments to clarify actions
* Update fetch until to check before fetch
* Fix linting errors
* Update CHANGELOG 1.7.0 fixes
* Update logs to go to Infinity
* use Date instead of moment for logs actions
* replace moment with Date where straightforward in LogsPage
* throw error from fetchEachAsync so consumers can handle it
* Fix infiniteTableData localStorage
* add minor todo for possible future tweak
* remove redundant error throw
* simplify a LogsPage use of Date
* move max tail buffer const next to tail chunk duration const for clarity
* clarify comments documenting logs actions and state
* run histogram & table query config requests in parallel
Co-authored-by: Delmer Reed <ofthedelmer@gmail.com>
Co-authored-by: Alex Paxton <thealexpaxton@gmail.com>
Co-authored-by: Jared Scheib <jared.scheib@gmail.com>
* Refactor ExpandableMessage to use React Portals
* Display "Clear Filters" button when more than 3 filters are present
* Move logs truncation toggle from options overlay to filter bar
* Simplify styles and markup
Ensure that the ... truncation happens
Showing a "zoom in" cursor when log messages can be clicked
* Update changelog
* Remove rogue file
* Type props in constructor and remove unecessary condition
* Remove spaces
* Add isSaveable condition for flux query in CEO
* Save flux query to cell in CEO
* Use flux query in Dashboard cell
* Move script state to cellEditorOverlay reducer
* Update Changelog
* Remove feature flag for allowFlux
* Update Children components of DisplayOptions to use props instead of individually connecting to redux and CEO visualization actions updated in prep for DE Vis
* Update DataExplorer to have visualization options
* Update timeSeriesToDygraph to not treat data explorer differently from ceo
* Remove featureflag from vis options in DE
* Update failing tests and rename cellNote to Note
* Update columns for table graph if in ceo or de, but not in dashboard
* Update Changelog
* Remove unnecessary getters from DisplayOptions
* Clone cells as close as possible to source cell
* Remove comments
* Cleaner way to handle cell cloning
* WIP
* Increment clone number by 1 when cloning
* Update changelog
* Make linter happy
* Pass array of cell names into function instead of dashboard object
* Improve legibility of math expression
* Update Visualization to get props from parent and not redux
* Update DataExplorer to use TimeMachine component and function like CEO
* Change dataExplorer to use time range from under dataExplorer in redux
* Change order of template variables
* Move shared actions/thunks between CEO and DE into one shared actions file
* Update tests with new reducers
* Fix types for editQueryStatus
* Remove unused components
* Fix typo
* Add Flux script to dataExplorer
* Update dataexplorer to persist what type of source its using
* Fix failing tests
* Change DE to use autorefresh dropdown from TimeMachineControls
* Update ChangeLog
* Fix failing test
* Remove unnecessary comment
* Provide default data explorer state for flux features
Co-authored-by: Iris Scholten <ischolten.is@gmail.com>
* Add FluxQueryEditor to CEO and move funcs to utils
* Use util functions in FluxPage
* Rename links to fluxLinks in TimeMachine
* Update Changelog
* Replace props with fluxContext
* feat: add Note string field to dashboard cells
* wip feat: html escape cell note to help prevent XSS attack
Requires further input to make sure this is effective at its
purpose.
* Add ability to view a cell's note from the cell header
* Make styles less brittle
* Add "chat" icon for use in notes
* Position note using cell X & Y
Avoid overlap with associated cell whenever possible
* New notes are empty strings by default
* Overflow note when contents are large
* Add react-markdown package for displaying markdown
* Display markdown in cell note
* Add a cell note text editor into the CEO
* Improve cell note editor
* Use codemirror placeholder addon
* Add placeholder to note field & foundation of markdown theme
* Add Markdown Cell
* Add initial styles for markdown cell contents
* Add graphic for Note type cell
* feat: add NoteVisibility to DashboardCell
* Add basic markdown syntax highlighting in editor
* Remove comment
* Show note in cell when queries return no data
* Make exception for rule graph
* Update fixtures and resources to fix tests
* Update changelog
* feat: sanitize xss-vulnerable note html
* Polish appearance of code samples in notes and note cells
* Replace ascii with plaintext before passing to markdown renderers
* Move "display when no results toggle" above text field
Less likely to go undiscovered
Template variables used within regexes would not replace when the query
contained a '/' before the regex in the query (see test).
This commit rewrites the logic for replacing template variables within
regexes.
Delmer
Alirie Gray
Iris Scholten
Russ Savage
Brandon Farmer
nathan haugo
alexpaxton
Lorenzo Fontana
Christopher Henn
Deniz Kusefoglu
Lorenzo Fontana
Andrew Watkins
Jared Scheib
Edd Robinson
Jared Scheib
Michael Desa
Chris Goller
Alex P
ebb-tide
Óscar de Arriba