Tim Raymond
a3db471abe
Extract option generator and task fetcher
...
The option generator goroutine and the task fetcher goroutine are more
readable when extracted into another method. Also, added some commenting
documenting what their expectations are
2017-08-23 16:21:13 -04:00
Tim Raymond
d560ab020a
Improve benchmark, fix offset bug
...
This ensures that setup time does not impact the results of the
benchmark since profiling showed that much time was spent setting up the
test array of tasks. This also uses `make` to build that slice instead.
Also, the tests revealed that there was a bug where offsets were
pre-incremented rather than post-incremented, omitting the first 100
results.
2017-08-22 10:23:24 -04:00
Tim Raymond
c3be40513d
Perf: improve performance of ListTasks
...
This fetches ListTasks results using a few worker goroutines to improve
performance with large numbers of tasks.
2017-08-21 17:10:13 -04:00
Tim Raymond
81f9e410f9
Fix issue where offset & limit won't work
...
Because we were testing the mock client, and not the paginating
kapacitor client for the case where limit and offset were provided, an
issue with that code path was not exposed.
The issues exposed were that the condition was incorrect for triggering
this behavior, and no return clause was present to prevent the remainder
of the ListTasks method from running.
2017-08-18 17:07:00 -04:00
Tim Raymond
01596453bd
Update comment
...
Variable name changed. Improved clarity.
2017-08-18 16:44:04 -04:00
Tim Raymond
886046ed9a
Switch KapacitorRulesGet to use Pagination
...
Kapacitor responses are paginated, and sometimes users have more than
the default 100 tasks that are returned from Kapacitor. This replaces
the previous Kapa client with one that automatically follows paginated
responses from Kapacitor's ListTasks endpoint and returns the full
response.
Tests for the KapacitorRulesGet endpoint had to be updated because they
did not account for "limit" and "offset", and so led to an infinite
loop with the paginated client. A correct kapacitor backend will not
have this behavior
2017-08-15 17:30:29 -04:00
Tim Raymond
d0be50ab37
Add PaginatingKapacitorClient
...
The kapacitor client used in the kapacitor endpoints is limited to
fetching whatever limit you provide it. If you provide no limit, it
defaults to a limit of 100. We use this default behavior currently.
Some users have more than 100 tasks, so we need a client that's capable
of continually fetching tasks from Kapacitor until there are none left,
and returning the full response to the frontend.
This introduces a PaginatingKapacitorClient which does exactly that.
Also, test coverage was added around the KapacitorRulesGet endpoint,
since it was previously untested.
2017-08-15 16:55:47 -04:00
Jared Scheib
4a20c28baf
Add space between functions
2017-07-21 19:57:31 -07:00
Jared Scheib
918dff33b7
Merge pull request #1724 from influxdata/feature/pushover_support-1680
...
Add Pushover alert support
2017-07-21 14:04:22 -07:00
Jared Scheib
9def502082
Fix PagerDuty kapacitor node typo bug ( #1751 )
...
* Fix pagerduty kapacitor node typo bug
* Update changelog
2017-07-21 13:54:49 -07:00
Jared Scheib
2cacc2507d
Update Kapacitor AST extract handlers to also guard against empty slices
2017-07-21 13:53:23 -07:00
Jared Scheib
928c4c2764
Fix and remove invalid Pushover alert node keys
2017-07-20 14:59:56 -07:00
Jared Scheib
a34ccb0189
Extract Pushover properties for Kapa alert via AST
2017-07-17 17:30:12 -07:00
Jared Scheib
0522bcdd60
Add Pushover as valid Kapacitor handler endpoint type
2017-07-17 17:29:26 -07:00
Chris Goller
c7ffac61a6
Update kapacitor alerts and ast to 1.3.1 features.
2017-07-14 21:09:39 -05:00
Andrew Watkins
02c63320f3
Add test for disabled bug
2017-06-20 11:42:19 -07:00
Andrew Watkins
7c22dfb09e
Fix enable / disable bug
2017-06-20 11:08:39 -07:00
Chris Goller
fcd334a214
Add test coverage to kapacitor client
2017-05-25 16:04:50 -05:00
Chris Goller
8d8ffd2bf5
Fix kapacitor PUT/POST returning request rather than response
2017-05-24 15:30:45 -07:00
Max Chadwick
2595a223ef
Test kapacitor log extraction
2017-05-14 22:09:15 -04:00
Max Chadwick
1416d617b1
Extract log from alerts
2017-05-14 22:01:08 -04:00
Max Chadwick
2b8abf1651
Add log alert tests
2017-05-14 21:42:41 -04:00
Max Chadwick
90afb717da
Add ability to log alerts
2017-05-12 22:04:38 -04:00
Chris Goller
d16286c505
Fix null queryConfig and add substantial test coverage to kapacitor
...
storage
2017-05-05 16:14:02 -05:00
Chris Goller
8aaed06402
Update Kapacitor alerts to set queryConfig to null if not parsable.
2017-05-05 14:30:20 -05:00
Andrew Watkins
014103adf6
Resolve conflicts
...
Conflicts:
ui/src/utils/influxql.js
2017-05-05 10:01:26 -07:00
Chris Goller
65231c2409
Update rawtext in queryconfig to be null and not omitempty
2017-04-07 17:32:10 -05:00
Chris Goller
88bd59d71a
Add ID for each kapacitor rule
2017-04-05 23:19:06 -05:00
Chris Goller
e83d95b937
Update kapacitors rule's to use AST and kapacitor directly
2017-04-05 20:04:42 -05:00
Chris Goller
b769370ce6
Add kapacitor AST tests for relative and deadman
2017-04-05 09:06:52 -05:00
Chris Goller
85ded628cd
Fix kapacitor AST regex parsing
2017-04-04 14:44:59 -05:00
Chris Goller
6ef73889b9
Add more tests to kapacitor AST to queryConfig
2017-04-04 10:58:11 -05:00
Chris Goller
293a1c5ee9
Add full kapacitor ast to chronograf.AlertRule with tests
2017-04-03 23:11:18 -05:00
Chris Goller
6864b039b4
Add alert nodes to kapacitor AST
2017-04-03 18:19:15 -05:00
Chris Goller
56378b4846
Add variable parsing for kapacitor AST
2017-04-03 10:40:10 -05:00
Chris Goller
c327337643
Add initial reversing of TICKscript to query config
2017-03-27 14:21:57 -05:00
Chris Goller
b60901e766
Add structured logging to underlying http server
2017-03-06 15:16:45 -06:00
Chris Goller
8dc012aeac
Update to fix go linter issues
2017-03-06 10:11:52 -06:00
Chris Goller
1d9bb70414
Add disable and enable to kapacitor alerts
2017-02-10 13:48:42 -06:00
Chris Goller
febc93a2c0
Update function name for kapacitor's formatting of values
2017-02-10 10:06:26 -06:00
Chris Goller
dac665b944
Add handling of string values for kapacitor threshold alerts
2017-02-10 08:47:08 -06:00
Chris Goller
9754f98dce
Add exec to supported kapacitor alerts
2017-02-09 00:29:19 -06:00
Chris Goller
8a62a15e39
Update kapacitor alert generation to support alerta
2017-02-09 00:23:46 -06:00
Chris Goller
bd6f3e1a6b
Add kapa alert arguments and properties
2017-02-09 00:10:23 -06:00
Chris Goller
98198dbf5b
Update kapacitor alert rule to have detail field
2017-02-07 17:09:14 -06:00
Hunter Trujillo
10a0ea1c14
Clarifying operator values.
2017-01-06 10:45:54 -07:00
Chris Goller
bf415e5eea
Update kapacitor alert rules to accept inside and outside range
2017-01-04 22:20:12 -06:00
Nathan Haugo
cc0ea821f0
Change direction of shift for relative rules ( #717 )
...
* Change direction of shift for relative rules
* Update changelog
* Fix tests
* Fix tests
* Update changelog for 718
2017-01-04 18:03:41 -06:00
Jade McGough
f57640124a
add kapacitor range alerting to API
2016-12-20 12:22:53 -08:00
Chris Goller
40190028e3
Fix problems found by https://github.com/dominikh/go-staticcheck
2016-11-14 11:04:32 -06:00
Chris Goller
72053466df
Fix kapacitor operators to be same as javascript
2016-11-14 10:17:44 -06:00
Chris Goller
c48bfe21b9
Fix #442 ; update tickscript to be disabled during script update followed by enable
2016-11-10 12:56:34 -06:00
Chris Goller
ff3d319866
Update tickscript generation to use group by time as period.
...
Add httpOut node
Remove spurious variables
2016-11-10 11:35:26 -06:00
Chris Goller
b20a4f6c62
Fix tickscript deadman output and use camelCase
2016-11-04 18:07:56 -05:00
Chris Goller
766ea60ba4
Add relative comparison with absolutes change
2016-11-04 17:25:57 -05:00
Chris Goller
943e555630
Update tickscript to evaluate between [0-100] instead of [0-1]
2016-11-04 17:05:18 -05:00
Chris Goller
b32274ac03
Fix lambda field strings to be double quoted
2016-11-04 16:35:12 -05:00
Chris Goller
12d22189c8
Fix tickscript generation of lambda funcs with var fields.
2016-11-04 16:28:28 -05:00
Chris Goller
c3bb854803
Fix bolt scoping and minor kapacitor tickscript updates
2016-11-03 22:25:41 -05:00
Chris Goller
dd6da581df
Update to store alert information in boltdb
2016-11-03 19:52:13 -05:00
Chris Goller
60baf46fb7
Update kapacitor generator to match with frontend UI changes.
2016-11-03 19:52:13 -05:00
Chris Goller
b99c721fa3
Update triggerType to be a tag in the output of alerts
2016-11-03 19:52:13 -05:00
Chris Goller
723a673075
Update kapacitor scripts based on reviews
2016-11-03 19:52:13 -05:00
Chris Goller
1ff551b03d
Add basic kapacitor task routes. Still need schema and storage
2016-11-03 19:52:13 -05:00
Chris Goller
8071717b65
Add kapacitor task creation/deletion/updating
2016-11-03 19:52:13 -05:00
Chris Goller
3679b8d741
Update tickscript lambda function generation to be sorted
2016-11-03 19:52:13 -05:00
Chris Goller
0f737b21d2
Update kapacitor tick generation to validate with pipeline
2016-11-03 19:52:13 -05:00
Chris Goller
08c8ada14f
Add kapacitor script generation
2016-11-03 19:52:13 -05:00
Chris Goller
476277f219
Add alert interface
2016-11-03 19:52:13 -05:00
Chris Goller
b7437da989
Add kapacitor tickscript template generator for threshold, relative, deadman
2016-11-03 19:52:00 -05:00
Chris Goller
d1359c09b3
Refactor to remove autogenerated code.
2016-10-26 22:10:52 -05:00
Chris Goller
91eec23099
Update name to chronograf
2016-10-20 09:39:40 -05:00
Chris Goller
f8fe71c5b9
Add kapacitors endpoint (persist/proxy/rest)
2016-10-04 12:48:36 -05:00