From e2dac89c7df4eb158dfed79a16ec2e068b20ed6e Mon Sep 17 00:00:00 2001 From: Jared Scheib Date: Wed, 26 Apr 2017 15:17:08 -0700 Subject: [PATCH] Make CSV values editable --- .../components/TemplateVariableRow.js | 43 +++++++++++++++++-- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git a/ui/src/dashboards/components/TemplateVariableRow.js b/ui/src/dashboards/components/TemplateVariableRow.js index d90932f19..4e099c35b 100644 --- a/ui/src/dashboards/components/TemplateVariableRow.js +++ b/ui/src/dashboards/components/TemplateVariableRow.js @@ -16,6 +16,31 @@ import {TEMPLATE_TYPES} from 'src/dashboards/constants' import q from 'src/dashboards/utils/onlyTheBigliestBigLeagueTemplateVariableQueryGenerator' +const RowValues = ({ + selectedType, + values = [], + isEditing, + onStartEdit, + autoFocusTarget, +}) => { + const _values = values.map(({value}) => value).join(', ') + + if (selectedType === 'csv') { + return ( + + ) + } + return values.length + ? {_values} + : (No values to display) +} + const TemplateVariableRow = ({ template: {id, label, tempVar, values}, isEditing, @@ -78,9 +103,13 @@ const TemplateVariableRow = ({ />
- {values.length - ? values.map(({value}) => value).join(', ') - : '(No values to display)'} +
{isEditing @@ -350,4 +379,12 @@ TableInput.propTypes = { autoFocusTarget: string, } +RowValues.propTypes = { + selectedType: string.isRequired, + values: arrayOf(shape()), + isEditing: bool.isRequired, + onStartEdit: func.isRequired, + autoFocusTarget: string, +} + export default OnClickOutside(RowWrapper)