Use getters to pass in elements directly instead of functions that return elements
parent
e0a93fd128
commit
daee2d9397
|
@ -111,7 +111,7 @@ class AlertsApp extends PureComponent<Props, State> {
|
|||
)
|
||||
}
|
||||
|
||||
private renderPageControls = (): JSX.Element => {
|
||||
private get renderPageControls(): JSX.Element {
|
||||
const {timeRange} = this.state
|
||||
|
||||
return (
|
||||
|
|
|
@ -59,7 +59,7 @@ class DashboardHeader extends Component<Props> {
|
|||
)
|
||||
}
|
||||
|
||||
private renderPageTitle = (): JSX.Element => {
|
||||
private get renderPageTitle(): JSX.Element {
|
||||
return (
|
||||
<>
|
||||
{this.dashboardSwitcher}
|
||||
|
@ -68,7 +68,7 @@ class DashboardHeader extends Component<Props> {
|
|||
)
|
||||
}
|
||||
|
||||
private renderPageControls = (): JSX.Element => {
|
||||
private get renderPageControls(): JSX.Element {
|
||||
const {
|
||||
handleChooseAutoRefresh,
|
||||
onManualRefresh,
|
||||
|
|
|
@ -186,7 +186,7 @@ export class DataExplorer extends PureComponent<Props, State> {
|
|||
return buildRawText(this.activeQuery, timeRange)
|
||||
}
|
||||
|
||||
private renderPageControls = (): JSX.Element => {
|
||||
private get renderPageControls(): JSX.Element {
|
||||
const {
|
||||
timeRange,
|
||||
autoRefresh,
|
||||
|
|
|
@ -27,7 +27,7 @@ class FluxHeader extends PureComponent<Props> {
|
|||
)
|
||||
}
|
||||
|
||||
private renderPageControls = (): JSX.Element => {
|
||||
private get renderPageControls(): JSX.Element {
|
||||
return (
|
||||
<button onClick={this.overlay} className="btn btn-sm btn-default">
|
||||
Edit Connection
|
||||
|
|
|
@ -28,7 +28,7 @@ class TickscriptHeader extends Component<Props> {
|
|||
)
|
||||
}
|
||||
|
||||
private renderPageControls = (): JSX.Element => {
|
||||
private get renderPageControls(): JSX.Element {
|
||||
const {
|
||||
task,
|
||||
onSave,
|
||||
|
|
|
@ -91,7 +91,7 @@ const PageContents: SFC<PageContentsProps> = ({children}) => (
|
|||
<div className="page">
|
||||
<PageHeader
|
||||
title="Manage Tasks"
|
||||
renderPageControls={renderPageControls}
|
||||
renderPageControls={renderHeaderOptions()}
|
||||
sourceIndicator={true}
|
||||
/>
|
||||
<FancyScrollbar className="page-contents fancy-scroll--kapacitor">
|
||||
|
@ -104,7 +104,7 @@ const PageContents: SFC<PageContentsProps> = ({children}) => (
|
|||
</div>
|
||||
)
|
||||
|
||||
const renderPageControls = (): JSX.Element => {
|
||||
const renderHeaderOptions = (): JSX.Element => {
|
||||
return (
|
||||
<QuestionMarkTooltip
|
||||
tipID="manage-tasks--tooltip"
|
||||
|
|
|
@ -38,7 +38,7 @@ class LogViewerHeader extends PureComponent<Props> {
|
|||
)
|
||||
}
|
||||
|
||||
private renderHeaderTitle = (): JSX.Element => {
|
||||
private get renderHeaderTitle(): JSX.Element {
|
||||
return (
|
||||
<>
|
||||
{this.status}
|
||||
|
@ -47,7 +47,7 @@ class LogViewerHeader extends PureComponent<Props> {
|
|||
)
|
||||
}
|
||||
|
||||
private renderPageControls = (): JSX.Element => {
|
||||
private get renderPageControls(): JSX.Element {
|
||||
const {timeRange} = this.props
|
||||
|
||||
return (
|
||||
|
|
|
@ -6,8 +6,8 @@ import SourceIndicator from 'src/shared/components/SourceIndicator'
|
|||
|
||||
interface Props {
|
||||
title?: string
|
||||
renderTitle?: () => ReactElement<any>
|
||||
renderPageControls?: () => ReactElement<any>
|
||||
renderTitle?: ReactElement<any>
|
||||
renderPageControls?: ReactElement<any>
|
||||
fullWidth?: boolean
|
||||
sourceIndicator?: boolean
|
||||
inPresentationMode?: boolean
|
||||
|
@ -55,7 +55,7 @@ class PageHeader extends Component<Props> {
|
|||
return <Title title={title} />
|
||||
}
|
||||
|
||||
return renderTitle()
|
||||
return renderTitle
|
||||
}
|
||||
|
||||
private get renderRight(): JSX.Element {
|
||||
|
@ -65,7 +65,7 @@ class PageHeader extends Component<Props> {
|
|||
return
|
||||
}
|
||||
|
||||
return renderPageControls()
|
||||
return renderPageControls
|
||||
}
|
||||
|
||||
private get className(): string {
|
||||
|
|
|
@ -61,7 +61,7 @@ class StatusPage extends Component {
|
|||
<PageHeader
|
||||
title="Status"
|
||||
fullWidth={true}
|
||||
renderPageControls={this.renderPageControls}
|
||||
renderPageControls={this.renderPageControls()}
|
||||
/>
|
||||
<FancyScrollbar className="page-contents">
|
||||
<div className="dashboard container-fluid full-width">
|
||||
|
|
Loading…
Reference in New Issue