Set kapacitor state in ConnectionWizard and call syncHostnames for new kapacitors
Co-authored-by: Deniz Kusefoglu <deniz@influxdata.com>pull/4906/head
parent
b345d01f8b
commit
ce7def3113
|
@ -2,6 +2,7 @@
|
||||||
|
|
||||||
### Bug Fixes
|
### Bug Fixes
|
||||||
1. [4895](https://github.com/influxdata/chronograf/pull/4895): Properly set scroll to row for table graph
|
1. [4895](https://github.com/influxdata/chronograf/pull/4895): Properly set scroll to row for table graph
|
||||||
|
1. [4906](https://github.com/influxdata/chronograf/pull/4906): Prevent Kapacitor URLs from being overwritten in Connection Wizard.
|
||||||
|
|
||||||
## v1.7.5 [2018-12-14]
|
## v1.7.5 [2018-12-14]
|
||||||
|
|
||||||
|
|
|
@ -134,6 +134,7 @@ class ConnectionWizard extends PureComponent<Props & WithRouterProps, State> {
|
||||||
setError={this.handleSetKapacitorError}
|
setError={this.handleSetKapacitorError}
|
||||||
kapacitor={kapacitor}
|
kapacitor={kapacitor}
|
||||||
showNewKapacitor={showNewKapacitor}
|
showNewKapacitor={showNewKapacitor}
|
||||||
|
setKapacitorDraft={this.setKapacitorDraft}
|
||||||
/>
|
/>
|
||||||
</WizardStep>
|
</WizardStep>
|
||||||
<WizardStep
|
<WizardStep
|
||||||
|
@ -223,6 +224,10 @@ class ConnectionWizard extends PureComponent<Props & WithRouterProps, State> {
|
||||||
return response
|
return response
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private setKapacitorDraft = (kapacitor: Kapacitor) => {
|
||||||
|
this.setState({kapacitor})
|
||||||
|
}
|
||||||
|
|
||||||
private handleKapacitorPrev = () => {}
|
private handleKapacitorPrev = () => {}
|
||||||
|
|
||||||
private handleSetKapacitorError = (b: boolean) => {
|
private handleSetKapacitorError = (b: boolean) => {
|
||||||
|
|
|
@ -42,6 +42,7 @@ interface Props {
|
||||||
setActiveKapacitor: sourcesActions.SetActiveKapacitor
|
setActiveKapacitor: sourcesActions.SetActiveKapacitor
|
||||||
fetchKapacitors: sourcesActions.FetchKapacitorsAsync
|
fetchKapacitors: sourcesActions.FetchKapacitorsAsync
|
||||||
showNewKapacitor?: boolean
|
showNewKapacitor?: boolean
|
||||||
|
setKapacitorDraft: (kapacitor: Kapacitor) => void
|
||||||
}
|
}
|
||||||
|
|
||||||
interface State {
|
interface State {
|
||||||
|
@ -73,20 +74,15 @@ class KapacitorStep extends Component<Props, State> {
|
||||||
constructor(props: Props) {
|
constructor(props: Props) {
|
||||||
super(props)
|
super(props)
|
||||||
|
|
||||||
const ActiveKapacitor = ActiveKapacitorFromSources(
|
const activeKapacitor =
|
||||||
props.source,
|
ActiveKapacitorFromSources(props.source, props.sources) || props.kapacitor
|
||||||
props.sources
|
|
||||||
)
|
|
||||||
|
|
||||||
let kapacitor
|
let kapacitor = syncHostnames(props.source, DEFAULT_KAPACITOR)
|
||||||
if (props.showNewKapacitor) {
|
|
||||||
kapacitor = DEFAULT_KAPACITOR
|
if (!props.showNewKapacitor && activeKapacitor) {
|
||||||
} else {
|
kapacitor = activeKapacitor
|
||||||
kapacitor = ActiveKapacitor || props.kapacitor || DEFAULT_KAPACITOR
|
|
||||||
}
|
}
|
||||||
|
|
||||||
kapacitor = syncHostnames(props.source, kapacitor)
|
|
||||||
|
|
||||||
this.state = {kapacitor}
|
this.state = {kapacitor}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -98,14 +94,19 @@ class KapacitorStep extends Component<Props, State> {
|
||||||
if (this.existingKapacitorHasChanged) {
|
if (this.existingKapacitorHasChanged) {
|
||||||
try {
|
try {
|
||||||
const {data: updatedKapacitor} = await updateKapacitor(kapacitor)
|
const {data: updatedKapacitor} = await updateKapacitor(kapacitor)
|
||||||
|
|
||||||
await this.fetchNewKapacitors()
|
await this.fetchNewKapacitors()
|
||||||
await pingKapacitor(updatedKapacitor)
|
await pingKapacitor(updatedKapacitor)
|
||||||
|
|
||||||
notify(notifyKapacitorUpdated())
|
notify(notifyKapacitorUpdated())
|
||||||
|
|
||||||
this.setState({kapacitor: updatedKapacitor})
|
this.setState({kapacitor: updatedKapacitor})
|
||||||
|
|
||||||
return {error: false, payload: updatedKapacitor}
|
return {error: false, payload: updatedKapacitor}
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error(error)
|
console.error(error)
|
||||||
notify(notifyCouldNotConnectToUpdatedKapacitor(kapacitor.name))
|
notify(notifyCouldNotConnectToUpdatedKapacitor(kapacitor.name))
|
||||||
|
|
||||||
return {error: true, payload: null}
|
return {error: true, payload: null}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -114,10 +115,14 @@ class KapacitorStep extends Component<Props, State> {
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const {data: newKapacitor} = await createKapacitor(source, kapacitor)
|
const {data: newKapacitor} = await createKapacitor(source, kapacitor)
|
||||||
|
|
||||||
await this.fetchNewKapacitors()
|
await this.fetchNewKapacitors()
|
||||||
await pingKapacitor(newKapacitor)
|
await pingKapacitor(newKapacitor)
|
||||||
|
|
||||||
this.setState({kapacitor: newKapacitor})
|
this.setState({kapacitor: newKapacitor})
|
||||||
|
|
||||||
notify(notifyKapacitorSuccess())
|
notify(notifyKapacitorSuccess())
|
||||||
|
|
||||||
return {error: false, payload: newKapacitor}
|
return {error: false, payload: newKapacitor}
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error(error)
|
console.error(error)
|
||||||
|
@ -142,10 +147,12 @@ class KapacitorStep extends Component<Props, State> {
|
||||||
}
|
}
|
||||||
|
|
||||||
private onChangeInput = (key: string) => (value: string | boolean) => {
|
private onChangeInput = (key: string) => (value: string | boolean) => {
|
||||||
const {setError} = this.props
|
const {setError, setKapacitorDraft} = this.props
|
||||||
const {kapacitor} = this.state
|
const {kapacitor} = this.state
|
||||||
|
|
||||||
this.setState({kapacitor: {...kapacitor, [key]: value}})
|
this.setState({kapacitor: {...kapacitor, [key]: value}}, () => {
|
||||||
|
setKapacitorDraft(this.state.kapacitor)
|
||||||
|
})
|
||||||
|
|
||||||
setError(false)
|
setError(false)
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue