From bda2521d7c63def6b57e68dad9a5bc5e607537bb Mon Sep 17 00:00:00 2001 From: Jared Scheib Date: Thu, 9 Mar 2017 13:59:10 -0800 Subject: [PATCH] Rename action to redux convention --- ui/spec/admin/reducers/adminSpec.js | 4 ++-- ui/src/admin/actions/index.js | 6 +++--- ui/src/admin/reducers/admin.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ui/spec/admin/reducers/adminSpec.js b/ui/spec/admin/reducers/adminSpec.js index d6c8177cf..7c3b132b6 100644 --- a/ui/spec/admin/reducers/adminSpec.js +++ b/ui/spec/admin/reducers/adminSpec.js @@ -2,7 +2,7 @@ import reducer from 'src/admin/reducers/admin' import { addUser, - confirmUserCreated, + createUserSuccess, editUser, loadRoles, deleteRole, @@ -69,7 +69,7 @@ describe('Admin.Reducers', () => { } state = {users: [u2, addedUser]} - const actual = reducer(state, confirmUserCreated(addedUser, u1)) + const actual = reducer(state, createUserSuccess(addedUser, u1)) const expected = { users: [u2, u1], } diff --git a/ui/src/admin/actions/index.js b/ui/src/admin/actions/index.js index 89ee020d2..3e6309686 100644 --- a/ui/src/admin/actions/index.js +++ b/ui/src/admin/actions/index.js @@ -29,8 +29,8 @@ export const addUser = () => ({ type: 'ADD_USER', }) -export const confirmUserCreated = (user, createdUser) => ({ - type: 'CONFIRM_USER_CREATED', +export const createUserSuccess = (user, createdUser) => ({ + type: 'CREATE_USER_SUCCESS', payload: { user, createdUser, @@ -109,7 +109,7 @@ export const createUserAsync = (url, user) => async (dispatch) => { try { const {data} = await createUserAJAX(url, user) dispatch(publishNotification('success', 'User created successfully')) - dispatch(confirmUserCreated(user, data)) + dispatch(createUserSuccess(user, data)) } catch (error) { // undo optimistic update dispatch(publishNotification('error', `Failed to create user: ${error.data.message}`)) diff --git a/ui/src/admin/reducers/admin.js b/ui/src/admin/reducers/admin.js index ba5f7d2cb..c78552de1 100644 --- a/ui/src/admin/reducers/admin.js +++ b/ui/src/admin/reducers/admin.js @@ -37,7 +37,7 @@ export default function admin(state = initialState, action) { } } - case 'CONFIRM_USER_CREATED': { + case 'CREATE_USER_SUCCESS': { const {user, createdUser} = action.payload const newState = { users: state.users.map(u => u.links.self === user.links.self ? {...createdUser} : u),