Influxdata
/
chronograf
mirror of https://github.com/influxdata/chronograf.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove super admin from store/sources tests 

Signed-off-by: Jared Scheib <jared.scheib@gmail.com>
pull/2249/head
Michael de Sa 2017-11-07 14:57:37 -05:00 committed by Jared Scheib
parent 4df7e38779
commit 85329d0bc6
1 changed files with 9 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
server/stores_test.go
View File

@ -16,7 +16,6 @@ func TestStore_SourcesGet(t *testing.T) {
SourcesStore chronograf.SourcesStore
}
type args struct {
superAdmin bool
organization string
role string
id int
@ -261,7 +260,7 @@ func TestStore_SourcesGet(t *testing.T) {
},
},
{
name: "Get source as super admin",
name: "No organization or role set on context",
fields: fields{
SourcesStore: &mocks.SourcesStore{
GetF: func(ctx context.Context, id int) (chronograf.Source, error) {
@ -274,22 +273,13 @@ func TestStore_SourcesGet(t *testing.T) {
},
},
},
args: args{
organization: "0",
role: "viewer",
superAdmin: true,
},
args: args{},
wants: wants{
source: chronograf.Source{
ID: 1,
Name: "my sweet name",
Organization: "0",
Role: "viewer",
},
err: true,
},
},
{
name: "Get source as super admin - no organization or role",
name: "Get source as viewer - no organization specified on context",
fields: fields{
SourcesStore: &mocks.SourcesStore{
GetF: func(ctx context.Context, id int) (chronograf.Source, error) {
@ -303,14 +293,14 @@ func TestStore_SourcesGet(t *testing.T) {
},
},
args: args{
superAdmin: true,
role: "viewer",
},
wants: wants{
err: true,
},
},
{
name: "Get source as super admin - no role",
name: "Get source as editor - no organization specified on context",
fields: fields{
SourcesStore: &mocks.SourcesStore{
GetF: func(ctx context.Context, id int) (chronograf.Source, error) {
@ -324,15 +314,14 @@ func TestStore_SourcesGet(t *testing.T) {
},
},
args: args{
superAdmin: true,
organization: "0",
role: "editor",
},
wants: wants{
err: true,
},
},
{
name: "Get source as super admin - no organization",
name: "Get source as admin - no organization specified on context",
fields: fields{
SourcesStore: &mocks.SourcesStore{
GetF: func(ctx context.Context, id int) (chronograf.Source, error) {
@ -346,8 +335,7 @@ func TestStore_SourcesGet(t *testing.T) {
},
},
args: args{
superAdmin: true,
role: "viewer",
role: "admin",
},
wants: wants{
err: true,
@ -363,10 +351,6 @@ func TestStore_SourcesGet(t *testing.T) {
ctx := context.Background()
if tt.args.superAdmin {
ctx = context.WithValue(ctx, SuperAdminKey, true)
}
if tt.args.organization != "" {
ctx = context.WithValue(ctx, organizations.ContextKey, tt.args.organization)
}