diff --git a/ui/spec/kapacitor/reducers/rulesSpec.js b/ui/spec/kapacitor/reducers/rulesSpec.js index c10aafdcb..fb49ab930 100644 --- a/ui/spec/kapacitor/reducers/rulesSpec.js +++ b/ui/spec/kapacitor/reducers/rulesSpec.js @@ -7,7 +7,7 @@ import { updateMessage, updateAlerts, updateRuleName, - deleteRule, + deleteRuleSuccess, } from 'src/kapacitor/actions/view'; describe('Kapacitor.Reducers.rules', () => { @@ -113,7 +113,7 @@ describe('Kapacitor.Reducers.rules', () => { }; expect(Object.keys(initialState).length).to.equal(2); - const newState = reducer(initialState, deleteRule(rule2)); + const newState = reducer(initialState, deleteRuleSuccess(rule2)); expect(Object.keys(newState).length).to.equal(1); expect(newState[rule1]).to.equal(initialState[rule1]); }); diff --git a/ui/src/kapacitor/actions/view/index.js b/ui/src/kapacitor/actions/view/index.js index 284a6ebd7..57b3e643c 100644 --- a/ui/src/kapacitor/actions/view/index.js +++ b/ui/src/kapacitor/actions/view/index.js @@ -109,16 +109,19 @@ export function updateRuleName(ruleID, name) { }; } +export function deleteRuleSuccess(ruleID) { + return { + type: 'DELETE_RULE_SUCCESS', + payload: { + ruleID, + }, + }; +} + export function deleteRule(rule) { return (dispatch) => { deleteRuleAPI(rule).then(() => { - dispatch({ - type: 'DELETE_RULE', - payload: { - ruleID: rule.id, - }, - }); - + dispatch(deleteRuleSuccess(rule.id)); dispatch(publishNotification('success', `${rule.name} deleted successfully`)); }).catch(() => { dispatch(publishNotification('error', `${rule.name} deleted successfully`)); diff --git a/ui/src/kapacitor/reducers/rules.js b/ui/src/kapacitor/reducers/rules.js index 12ae63452..57acb91c6 100644 --- a/ui/src/kapacitor/reducers/rules.js +++ b/ui/src/kapacitor/reducers/rules.js @@ -80,7 +80,7 @@ export default function rules(state = {}, action) { }); } - case 'DELETE_RULE': { + case 'DELETE_RULE_SUCCESS': { const {ruleID} = action.payload; delete state[ruleID]; return Object.assign({}, state);