From 7bb955baa3fbf670ca89c0a7204078ad091ce294 Mon Sep 17 00:00:00 2001 From: lukevmorris Date: Thu, 30 Mar 2017 11:27:51 -0700 Subject: [PATCH] Active sidebar items should have a blue indicator (#1132) * NavBlocks without NavListItem children are valid Some sidebar NavBlocks consist of just a header, and clicking on that header should mark the NavBlock as active * Update CHANGELOG * Leverage markdown to cut down on merge conflicts --- CHANGELOG.md | 3 ++- ui/src/side_nav/components/NavItems.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 432466eea..8aed1b791 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ### Bug Fixes 1. [#1104](https://github.com/influxdata/chronograf/pull/1104): Fix windows hosts on host list - 2. [#1125](https://github.com/influxdata/chronograf/pull/1125): Fix visualizations not showing graph name + 1. [#1125](https://github.com/influxdata/chronograf/pull/1125): Fix visualizations not showing graph name ### Features 1. [#1112](https://github.com/influxdata/chronograf/pull/1112): Add ability to delete a dashboard @@ -12,6 +12,7 @@ ### UI Improvements 1. [#1101](https://github.com/influxdata/chronograf/pull/1101): Compress InfluxQL responses with gzip + 1. [#1132](https://github.com/influxdata/chronograf/pull/1132): All sidebar items show activity with a blue strip ## v1.2.0-beta7 [2017-03-28] ### Bug Fixes diff --git a/ui/src/side_nav/components/NavItems.js b/ui/src/side_nav/components/NavItems.js index ae3cb5fc7..58156b46e 100644 --- a/ui/src/side_nav/components/NavItems.js +++ b/ui/src/side_nav/components/NavItems.js @@ -47,7 +47,7 @@ const NavBlock = React.createClass({ const {location, className, wrapperClassName} = this.props const isActive = React.Children.toArray(this.props.children).find((child) => { - return child.type === NavListItem && location.startsWith(child.props.link) + return location.startsWith(child.props.link) }) const children = React.Children.map((this.props.children), (child) => {