From 6dfba05ac359a5d0cd159a2c246204110b8f8fac Mon Sep 17 00:00:00 2001
From: Alex P <thealexpaxton@gmail.com>
Date: Wed, 27 Jun 2018 16:23:52 -0700
Subject: [PATCH] Position legend using hover time

---
 ui/src/shared/components/DygraphLegend.tsx |  9 +++++++--
 ui/src/shared/graphs/helpers.ts            | 17 ++++++++---------
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/ui/src/shared/components/DygraphLegend.tsx b/ui/src/shared/components/DygraphLegend.tsx
index 86ab96e27..339503f9d 100644
--- a/ui/src/shared/components/DygraphLegend.tsx
+++ b/ui/src/shared/components/DygraphLegend.tsx
@@ -15,6 +15,7 @@ import {NO_CELL} from 'src/shared/constants'
 import {DygraphClass} from 'src/types'
 
 interface Props {
+  hoverTime: number
   dygraph: DygraphClass
   cellID: string
   onHide: () => void
@@ -256,10 +257,13 @@ class DygraphLegend extends PureComponent<Props, State> {
 
   private get styles() {
     const {
+      dygraph,
       dygraph: {graphDiv},
+      hoverTime,
     } = this.props
-    const {pageX} = this.state
-    return makeLegendStyles(graphDiv, this.legendRef, pageX)
+
+    const legendPosition = dygraph.toDomXCoord(hoverTime)
+    return makeLegendStyles(graphDiv, this.legendRef, legendPosition)
   }
 }
 
@@ -269,6 +273,7 @@ const mapDispatchToProps = {
 
 const mapStateToProps = ({dashboardUI}) => ({
   activeCellID: dashboardUI.activeCellID,
+  hoverTime: +dashboardUI.hoverTime,
 })
 
 export default connect(mapStateToProps, mapDispatchToProps)(DygraphLegend)
diff --git a/ui/src/shared/graphs/helpers.ts b/ui/src/shared/graphs/helpers.ts
index b9f34b483..cd794abfa 100644
--- a/ui/src/shared/graphs/helpers.ts
+++ b/ui/src/shared/graphs/helpers.ts
@@ -114,8 +114,8 @@ export const barPlotter = e => {
   }
 }
 
-export const makeLegendStyles = (graph, legend, pageX) => {
-  if (!graph || !legend || pageX === null) {
+export const makeLegendStyles = (graph, legend, hoverTimeX) => {
+  if (!graph || !legend || hoverTimeX === null) {
     return {}
   }
 
@@ -131,21 +131,20 @@ export const makeLegendStyles = (graph, legend, pageX) => {
   const legendHeight = legendRect.height
   const screenHeight = window.innerHeight
   const legendMaxLeft = graphWidth - legendWidth / 2
-  const trueGraphX = pageX - graphRect.left
 
-  let legendLeft = trueGraphX
+  let legendLeft = hoverTimeX
 
   // Enforcing max & min legend offsets
-  if (trueGraphX < legendWidth / 2) {
+  if (hoverTimeX < legendWidth / 2) {
     legendLeft = legendWidth / 2
-  } else if (trueGraphX > legendMaxLeft) {
+  } else if (hoverTimeX > legendMaxLeft) {
     legendLeft = legendMaxLeft
   }
 
   // Disallow screen overflow of legend
   const isLegendBottomClipped = graphBottom + legendHeight > screenHeight
   const isLegendTopClipped = legendHeight > graphRect.top - chronografChromeSize
-  const willLegendFitLeft = pageX - chronografChromeSize > legendWidth
+  const willLegendFitLeft = hoverTimeX - chronografChromeSize > legendWidth
 
   let legendTop = graphHeight + 8
 
@@ -159,10 +158,10 @@ export const makeLegendStyles = (graph, legend, pageX) => {
     legendTop = 0
 
     if (willLegendFitLeft) {
-      legendLeft = trueGraphX - legendWidth / 2
+      legendLeft = hoverTimeX - legendWidth / 2
       legendLeft -= 8
     } else {
-      legendLeft = trueGraphX + legendWidth / 2
+      legendLeft = hoverTimeX + legendWidth / 2
       legendLeft += 32
     }
   }