Rename runTemplateVariableQuery to getTempVarValuesBySourceQuery for clarity

pull/3556/head
Jared Scheib 2018-06-01 17:44:46 -07:00
parent 3500f715c3
commit 2e655f46fb
3 changed files with 12 additions and 7 deletions

View File

@ -9,7 +9,7 @@ import {
updateDashboardCell as updateDashboardCellAJAX,
addDashboardCell as addDashboardCellAJAX,
deleteDashboardCell as deleteDashboardCellAJAX,
runTemplateVariableQuery,
getTempVarValuesBySourceQuery,
} from 'src/dashboards/apis'
import {notify} from 'shared/actions/notifications'
@ -337,7 +337,9 @@ export const hydrateTempVarValues = (source, dashboard) => async dispatch => {
)
const asyncQueries = tempsWithQueries.map(({query}) =>
runTemplateVariableQuery(source, {query: makeQueryForTemplate(query)})
getTempVarValuesBySourceQuery(source, {
query: makeQueryForTemplate(query),
})
)
const results = await Promise.all(asyncQueries)

View File

@ -87,7 +87,7 @@ export const editTemplateVariables = async templateVariable => {
}
}
export const runTemplateVariableQuery = async (
export const getTempVarValuesBySourceQuery = async (
source,
{
query,

View File

@ -14,7 +14,7 @@ import TableInput from 'src/dashboards/components/template_variables/TableInput'
import RowValues from 'src/dashboards/components/template_variables/RowValues'
import ConfirmButton from 'src/shared/components/ConfirmButton'
import {runTemplateVariableQuery as runTemplateVariableQueryAJAX} from 'src/dashboards/apis'
import {getTempVarValuesBySourceQuery as getTempVarValuesBySourceQueryAJAX} from 'src/dashboards/apis'
import parsers from 'shared/parsing'
@ -203,7 +203,10 @@ class RowWrapper extends Component {
if (type === 'csv') {
parsedData = e.target.values.value.split(',').map(value => value.trim())
} else {
parsedData = await this.runTemplateVariableQuery(source, queryConfig)
parsedData = await this.getTempVarValuesBySourceQuery(
source,
queryConfig
)
}
onRunQuerySuccess(template, queryConfig, compact(parsedData), tempVar)
@ -264,12 +267,12 @@ class RowWrapper extends Component {
this.setState({selectedTagKey: item.text})
}
runTemplateVariableQuery = async (
getTempVarValuesBySourceQuery = async (
source,
{query, database, rp, tempVars, type, measurement, tagKey}
) => {
try {
const {data} = await runTemplateVariableQueryAJAX(source, {
const {data} = await getTempVarValuesBySourceQueryAJAX(source, {
query,
db: database,
rp,